-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Portal Wire Protocol a framework for discv5 #8629
base: master
Are you sure you want to change the base?
Conversation
File
|
The commit b14a030 (as a parent of 7a569b8) contains errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use backticks for non-code. I'd recommend using italics instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this file doesn't have a license, I don't think we can include it in our repository. The other alternative is to allow BitTorrent Extension Proposals as an origin for external links. See EIP-5757 for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we can link to ethereum/portal-network-specs
I will remove this
@SamWilsn ready for an another review |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
I addressed all feedback and I am ready for a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no point in having an EIP where the whole specification section is defined in another document. Implementers can just, you know, read that document instead.
May I ask why you're making this proposal? We can probably figure something out.
A draft PR for
Portal Wire Protocol
The foundation of other Portal Networks.