Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Network Upgrade Inclusion Stages #8662

Merged
merged 8 commits into from
Jul 4, 2024

Conversation

timbeiko
Copy link
Contributor

@timbeiko timbeiko commented Jun 12, 2024

Meta EIP to define Proposed for Inclusion, Considered for Inclusion, Schedule for Inclusion and Included. When merged, this EIP should replace this.

Signed-off-by: Tim Beiko <[email protected]>
@timbeiko timbeiko requested a review from eth-bot as a code owner June 12, 2024 21:55
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-meta labels Jun 12, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 12, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jun 12, 2024
@eth-bot eth-bot changed the title Add CFI EIP Add EIP: Network Upgrade Inclusion Stages Jun 12, 2024
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 12, 2024
EIPS/eip-cfi.md Outdated
@@ -0,0 +1,80 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
---
eip: 7723

Assigning next sequential EIP/ERC/RIP number.

Please also update the filename.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
---
eip: 7723

Assigning next sequential EIP/ERC/RIP number.

Please also update the filename.

EIPS/eip-cfi.md Outdated Show resolved Hide resolved
@timbeiko
Copy link
Contributor Author

Thanks @abcoathup, updated with the number and based on your feedback on EthMag

Copy link

The commit fa1aad7 (as a parent of e3f36f8) contains errors.
Please inspect the Run Summary for details.

@gorondan
Copy link

gorondan commented Jun 13, 2024

Meta EIP to define Proposed for Inclusion, Considered for Inclusion, Schedule for Inclusion and Included. When merged, this EIP should replace this.

These changes will bring more clarity in tracking the status of an EIP during the network upgrade process 👍

ethereum/pm#1069 (comment)

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 13, 2024
EIPS/eip-7723.md Outdated Show resolved Hide resolved
Copy link
Contributor

@abcoathup abcoathup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one minor grammar issue, LGTM

EIPS/eip-7723.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew B Coathup <[email protected]>
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta proposals can completely ignore eipw, so set the sections up in a way that makes the most sense for this document. Just keep abstract and copyright.

I'd use italics instead of backticks for your keywords, since backticks are generally for inline code.

@eth-bot eth-bot enabled auto-merge (squash) July 4, 2024 14:42
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 2ba7edf into ethereum:master Jul 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants