-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Network Upgrade Inclusion Stages #8662
Conversation
Signed-off-by: Tim Beiko <[email protected]>
✅ All reviewers have approved. |
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
EIPS/eip-cfi.md
Outdated
@@ -0,0 +1,80 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- | |
--- | |
eip: 7723 |
Assigning next sequential EIP/ERC/RIP number.
Please also update the filename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
--- --- eip: 7723 Assigning next sequential EIP/ERC/RIP number.
Please also update the filename.
Signed-off-by: Tim Beiko <[email protected]>
Thanks @abcoathup, updated with the number and based on your feedback on EthMag |
The commit fa1aad7 (as a parent of e3f36f8) contains errors. |
These changes will bring more clarity in tracking the status of an EIP during the network upgrade process 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than one minor grammar issue, LGTM
Co-authored-by: Andrew B Coathup <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meta proposals can completely ignore eipw
, so set the sections up in a way that makes the most sense for this document. Just keep abstract and copyright.
I'd use italics instead of backticks
for your keywords, since backticks are generally for inline code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Meta EIP to define
Proposed for Inclusion
,Considered for Inclusion
,Schedule for Inclusion
andIncluded
. When merged, this EIP should replace this.