EIP-2981: ERC-721 Royalty standard - Standardized means of accepting royalties for NFT marketplaces across the ecosystem #2981
Conversation
|
Hey @MicahZoltu - what am I missing that made this CI check fail? Anything look out of place to you? Says its failing on my last commit which was just changing some spacing on a code bracket |
EIPS/EIP-1776.md
Outdated
| title: ERC-721 Royalty Standard | ||
| author: Zach Burks (@vexycats) | ||
| discussions-to: https://github.com/ethereum/EIPs/issues/2907 | ||
| status: First Draft |
There was a problem hiding this comment.
| status: First Draft | |
| status: Draft |
|
Also, you have several typos that the bot doesn't like: |
|
Hey thanks! No spell check in my IDE ;D Will go through and check everything for typos on an external program and resubmit! (Didn't know typos affected the PR acceptance) |
There was a problem hiding this comment.
I left a bunch of feedback which I encourage you to consider, but for getting this merged as a Draft all that is required is that the EIP is structurally sound (meaning you have the right sections and the frontmatter is setup correctly).
Since I left some inline suggestions in here, I'll wait for you to indicate you want me to merge since once I merge you can't do one-click apply of the inline suggestions anymore.
EIPS/EIP-1776.md
Outdated
|
|
||
| **ERC-721 compliant contracts MAY implement this ERC for royalties to provide a standard method of accepting royalty payments and recieving royalty information** | ||
|
|
||
| The `_RoyaltyAmount` **MUST** be calculated as a percentage - such as "5" - for 5%. This is **REQUIRED** to maintain uniformity across the standard. |
There was a problem hiding this comment.
This limits minimum royalties to 1%. Recommend having a much lower minimum. One option is to have two fields, one for the numerator and one for the denominator. Another option is to just have this be a fixed point percentage (in the range 0 to 1) with a scaling factor of 10^18. A final option would be to have this be fixed point with a scaling factor of 10000 or something.
Note: Currently, this is value is a multiplier on the amount that is a fixed point value with scaling factor of 100.
There was a problem hiding this comment.
I choose fixed point with scaling to 100 as all the other marketplaces with royalties do not let you go below 1%, with the average royalty percentage being 1-10%.
I'm not opposed to making it go lower. I'm not sure which would be best, a scaling factor of 10,000, or scaled to 10^18.
Most users would not need/select a percentage of 0.00005% though - as an NFT purchase is a onetime transaction and not like a general fee on all transactions on something like say uniswap.
Continuing to go through these and replying. Thank you for the feedback Michah!
There was a problem hiding this comment.
I used 10,000 as the scaling factor as I don't see any reason someone would want to go below that for an NFT royalty fee.
Im unsure if its a good move, as for adopting the standard a marketplace really needs to make sure its math is correct and it uses the 10000 scale factor, otherwise it might have a bad time..... I'd like an easier solution where it requires less math/attention to detail for implementation, but alas I don't know of what would be better
There was a problem hiding this comment.
The advantage of 10^18 is that it is very standard across Ethereum, so it is more likely that tools will "just work" with that then with some custom scaling factor. The advantage of 100 is that it is easy to just describe the value as a "percentage". Personally, I would just do 10^18 I think because I believe that 100 is way too limiting (I can imagine people wanting sub percentage royalties) and I think standardization is valuable. You aren't really saving anything by using 10,000 as all numbers in Solidity use the same number of bytes of storage (unless you are bit packing, which I don't think you are or should).
VexyCats
changed the title
|
@MicahZoltu I think I've made all the changes - please feel free to merge the PR, unless you have any other feedback. As we get more discussions and thoughts on it can always propose changes Thank you for your feedback so far! |
…royalties for NFT marketplaces across the ecosystem (ethereum#2981) A standardized way to handle royalty payments for ERC-721 tokens, including publicly viewable information and notification of payment event.
…royalties for NFT marketplaces across the ecosystem (ethereum#2981) A standardized way to handle royalty payments for ERC-721 tokens, including publicly viewable information and notification of payment event.
full EIP text here : https://github.com/VexyCats/EIPs/blob/master/EIPS/eip-2981.md
Conversation here : #2907 #2907