-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERC: Account Abstraction via Entry Point Contract specification #4337
Conversation
An account abstraction proposal which completely avoids the need for consensus-layer protocol changes, instead relying on a separate mempool of `UserOperation` objects and miners either running custom code or connecting to a bundle marketplace.
Nice work! It would be nice to allow out-of-order execution of transactions, which could be done by creating a wallet with a more elaborate nonce than just an integer. Here's an example of a Nonce implementation that stores the actual nonce (a 128-bit number) and a bitregister (of 128 bits) in the same uint256 in order to support out-of-order execution of up to 100 or so transactions: https://github.com/aktionariat/contracts/blob/master/src/Nonce.sol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments - the Security Considerations
and Copyright
sections are missing currently. Thanks!
I'm trying to stay out of ERCs... but since I happened to read this one: |
EIP file name must be eip-###.md |
The latter is referring to one of the lines in the frontmatter. |
Agree with consensus.
Looks good to me. Green light.
On Mon, 4 Oct 2021 at 05:43, Micah Zoltu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In EIPS/eip-4337.md
<#4337 (comment)>:
> @@ -0,0 +1,331 @@
+---
+eip: 4337
+title: Account Abstraction via Entry Point Contract specification
+description: An account abstraction proposal which completely avoids consensus-layer protocol changes, instead relying on higher-layer infrastructure.
+author: Vitalik Buterin ***@***.***), Yoav Weiss ***@***.***), Kristof Gazso ***@***.***), Namra Patel ***@***.***), Dror Tirosh ***@***.***)
⬇️ Suggested change
-author: Vitalik Buterin ***@***.***), Yoav Weiss ***@***.***), Kristof Gazso ***@***.***), Namra Patel ***@***.***), Dror Tirosh ***@***.***)
+ author: Vitalik Buterin ***@***.***), Yoav Weiss ***@***.***), Kristof Gazso ***@***.***), Namra Patel ***@***.***), Dror Tirosh ***@***.***)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4337 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALPDOTO5PQEPUZFU2O5RBDUFEWH5ANCNFSM5E7KWLYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Sent from iPhone
|
Co-authored-by: Micah Zoltu <[email protected]>
Co-authored-by: Micah Zoltu <[email protected]>
@alita-moore Any idea why CI is failing on this? This is the error, but the file name appears to correctly match the desired pattern.
|
It's likely just because it also touches assets which is not supported. Even still it should be giving a much more detailed report so I'll look into that. |
Gah, that was my bad. I didn't see the asset files in the list. I think we already have a ticket for allowing asset changes for an EIP being allowed under the same rules as changing an EIP. |
@MicahZoltu do you mind merging? I don't have admin access to override the bot. Ty. |
…reum#4337) * Account Abstraction via Entry Point Contract specification An account abstraction proposal which completely avoids the need for consensus-layer protocol changes, instead relying on a separate mempool of `UserOperation` objects and miners either running custom code or connecting to a bundle marketplace. * Rename file to match ERC number * Update eip-4337.md * Apply suggestions from code review Co-authored-by: lightclient <[email protected]> * Replaced simple summary with abstract * Apply suggestions from code review * Changing to relative links for images * Update EIPS/eip-4337.md * Added mandatory sections * reference EIP-2470 (create2 deployer) (ethereum#4344) * Made EIP links relative * Update EIPS/eip-4337.md Co-authored-by: Micah Zoltu <[email protected]> * Update EIPS/eip-4337.md Co-authored-by: Micah Zoltu <[email protected]> * Update EIPS/eip-4337.md * Update EIPS/eip-4337.md * Update EIPS/eip-4337.md * add images for eip-4337 Co-authored-by: lightclient <[email protected]> Co-authored-by: Dror Tirosh <[email protected]> Co-authored-by: Micah Zoltu <[email protected]> Co-authored-by: [email protected] <[email protected]>
cool!!! |
|
An account abstraction proposal which completely avoids the need for consensus-layer protocol changes, instead relying on a separate mempool of
UserOperation
objects and miners either running custom code or connecting to a bundle marketplace.