Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1776: Legal Governance Token Standard #4713

Closed
wants to merge 13 commits into from
Closed

Conversation

j0xhn
Copy link

@j0xhn j0xhn commented Jan 23, 2022

No description provided.

@eth-bot
Copy link
Collaborator

eth-bot commented Jan 23, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) EIPS/eip-1776.md

classification
ambiguous
  • A 'type' header is required for all EIPs, 'eip-1776.md' does not have a 'type'

@j0xhn j0xhn changed the title [ WIP ] 1776 => Extend any DAO framework for compliance with local legal jurisdictions EIP-1776: DAO framework for compliance within local legal jurisdictions Jan 23, 2022
@j0xhn j0xhn marked this pull request as draft January 23, 2022 08:49
EIPS/eip-1776.md Outdated Show resolved Hide resolved
EIPS/eip-1776.md Outdated Show resolved Hide resolved
EIPS/eip-1776.md Outdated Show resolved Hide resolved
@j0xhn j0xhn changed the title EIP-1776: DAO framework for compliance within local legal jurisdictions EIP-1776: Legal Governance Token Standard Jan 26, 2022
@poojaranjan
Copy link
Contributor

As per the EIP-1, an EIP number is determined by the EIP editor(s), which in most cases is the pull request number of the "Draft" proposal. This proposal seems to be relatively new. However, the EIP number seems to be from old series.
@j0xhn Do you happen to have any old reference for this proposal that you would like to add?

Additional changes requested:

  • Remove "Table of contents" & "Simple Summary" from Table of Content as they not a standard content for an EIP
  • Add "Description" to preamble

"Simple Summary" has been replaced by "Description". Please check EIP Formats and Template for reference.

@j0xhn
Copy link
Author

j0xhn commented Jan 26, 2022 via email

@poojaranjan
Copy link
Contributor

Thanks for the response, @j0xhn.

Historically, allocation of EIP number is editors' responsibility. Tagging EIP editors to weigh in @MicahZoltu @axic @lightclient @gcolvin

@wighawag
Copy link
Contributor

Note that 1776 is already used : #1776
The issue is closed but that was due to auto bot and can be reopened

EIPS/eip-1776.md Outdated Show resolved Hide resolved
EIPS/eip-1776.md Outdated Show resolved Hide resolved
EIPS/eip-1776.md Outdated Show resolved Hide resolved
EIPS/eip-1776.md Outdated Show resolved Hide resolved
EIPS/eip-1776.md Outdated Show resolved Hide resolved
j0xhn and others added 6 commits February 13, 2022 14:27
Co-authored-by: Micah Zoltu <[email protected]>
Co-authored-by: Micah Zoltu <[email protected]>
Co-authored-by: Micah Zoltu <[email protected]>
Co-authored-by: Micah Zoltu <[email protected]>
Co-authored-by: Micah Zoltu <[email protected]>
Co-authored-by: Micah Zoltu <[email protected]>
@j0xhn
Copy link
Author

j0xhn commented Feb 13, 2022

Merge suggestions from editors

@j0xhn
Copy link
Author

j0xhn commented Mar 6, 2022

@wighawag I received permission to re-open 1776 with this being a meta-standard. Is that something we add to their issue thread? Possible to re-open those? Didn't see anything on my end so figured perhaps there are certain admin functionalities you are possibly privy to?

jØxhn Ð $tǿr£y added 2 commits March 6, 2022 22:56
@wighawag
Copy link
Contributor

wighawag commented Mar 8, 2022

@wighawag I received permission to re-open 1776 with this being a meta-standard. Is that something we add to their issue thread? Possible to re-open those? Didn't see anything on my end so figured perhaps there are certain admin functionalities you are possibly privy to?

Not sure I understand the question

What I am saying is that EIP-1776 already exists and so you ll have to use another number

@MicahZoltu
Copy link
Contributor

@wighawag There is no EIP-1776.

@j0xhn In order to take over authorship of an existing EIP, you will need to get the authors to add you to the authors list. This requires a PR to an existing EIP and the existing authors to approve that PR. In this case, there is no EIP-1776 so there is no EIP to take over authorship of. When creating a new EIP, editors will assign a number. Numbers aren't something that EIP authors get to choose. Number selection is a nearly automated (but not fully automated) process. If you want a memorable EIP you should come up with a memorable title and a quality EIP, the number is just meant to be a unique identifier.

@wighawag
Copy link
Contributor

wighawag commented Mar 9, 2022

@MicahZoltu

Well my point is that there is already usage of the EIP-1776 name in that draft: #1776

The fact that as part of EIP guideline, it is common to use the issue/PR number as the number to be given to the EIP when merged, it is normal to expect that draft to use that number when it merge.

And this guideline is actually important, It allows EIP author to feel confident of the stability of the number when mentioning it elsewhere.

While the issue is currently closed, it could be re-open and there are already several references to it in the outside :

@MicahZoltu
Copy link
Contributor

MicahZoltu commented Mar 9, 2022

Well my point is that there is already usage of the EIP-1776 name in that draft: #1776

Unless there is a PR that actually get merged, there is no EIP, and thus no number. People mention numbers all the time, but the official policy is that if there is no merged Draft, then there is no EIP.

And this guideline is actually important, It allows EIP author to feel confident of the stability of the number when mentioning it elsewhere.

We are extremely explicit that you don't have a number until it is assigned! You SHOULD NOT be talking about a numbered EIP until there is a draft. Just because people do a thing doesn't mean it is correct. 😀 In fact, I have a pretty strong inclination to intentionally assign a different number once a draft EIP is actually created just to make it very clear to people that numbers are assigned by editors, and until you have a merged Draft EIP you don't have a number.

@wighawag
Copy link
Contributor

wighawag commented Mar 9, 2022

ok, point taken

Just because people do a thing doesn't mean it is correct.

Well that depends :) (this how language works :) )

@github-actions github-actions bot added the stale label May 8, 2022
@github-actions github-actions bot closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants