Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5008: Move to Final #7118

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Update EIP-5008: Move to Final #7118

merged 2 commits into from
Jul 13, 2023

Conversation

emojidao
Copy link
Contributor

@emojidao emojidao commented Jun 1, 2023

Update EIP-5008: Move to Final

@emojidao emojidao requested a review from eth-bot as a code owner June 1, 2023 02:59
@github-actions github-actions bot added c-status Changes a proposal's status s-final This EIP is Final t-erc labels Jun 1, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 1, 2023

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Jun 1, 2023
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @emojidao congrats on almost getting there! QQ, did you deployed your reference implementation or any compliant implementation somewhere? Preferably Ethereum Mainnet or any ETH testnet? Can you share the address?

@0xanders
Copy link
Contributor

0xanders commented Jun 1, 2023

@xinbenlv
Copy link
Contributor

xinbenlv commented Jun 1, 2023

I would personally prefer to see deployment of compliant implementation before finalizing an EIP.

@github-actions github-actions bot added c-update Modifies an existing proposal and removed c-status Changes a proposal's status s-final This EIP is Final labels Jul 13, 2023
@eth-bot eth-bot enabled auto-merge (squash) July 13, 2023 14:21
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit d1db66f into ethereum:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants