-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-5008: Move to Final #7118
Conversation
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @emojidao congrats on almost getting there! QQ, did you deployed your reference implementation or any compliant implementation somewhere? Preferably Ethereum Mainnet or any ETH testnet? Can you share the address?
Some contracts with nonce property, but the function name is https://etherscan.io/address/0x935329bcea69afbd8a0627d111a30bc3b433f7a2#code |
I would personally prefer to see deployment of compliant implementation before finalizing an EIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Update EIP-5008: Move to Final