Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add eth_signTypedData as a standard for machine-verifiable and human-readable typed data signing with Ethereum keys #712

Merged
merged 58 commits into from
Jun 9, 2018
Merged

[WIP] Add eth_signTypedData as a standard for machine-verifiable and human-readable typed data signing with Ethereum keys #712

merged 58 commits into from
Jun 9, 2018

Commits on Apr 9, 2018

  1. Add eip-signTypedData

    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    21abe25 View commit details
    Browse the repository at this point in the history

  2. Change namespace from personal to eth

    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    69e486b View commit details
    Browse the repository at this point in the history

  3. Change a way schema hash is combined together with data as proposed by … 

    …@MicahZoltu
    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    75904fc View commit details
    Browse the repository at this point in the history

  4. Add a note about it being implemented in MetaMask as an experimental … 

    …feature
    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    cfa56eb View commit details
    Browse the repository at this point in the history

  5. Add signerAddress as a parameter

    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    1dd2fbe View commit details
    Browse the repository at this point in the history

  6. Add test vectors

    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    597cdd7 View commit details
    Browse the repository at this point in the history

  7. Fix an example

    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    e22ba32 View commit details
    Browse the repository at this point in the history

  8. Missing commas, periods

    @pirapira @recmo
    pirapira authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    12696f8 View commit details
    Browse the repository at this point in the history

  9. Address the feedback

    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    b4e5d70 View commit details
    Browse the repository at this point in the history

  10. Add a missing signerAddress parameter in the example

    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    ec20713 View commit details
    Browse the repository at this point in the history

  11. Change the order of parameters to have an address as a second arg

    @LogvinovLeon @recmo
    LogvinovLeon authored and recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    745963a View commit details
    Browse the repository at this point in the history

  12. Wrote motivation

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    dab73be View commit details
    Browse the repository at this point in the history

  13. WIP

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    6d7d340 View commit details
    Browse the repository at this point in the history

  14. First draft of specification

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    c098c14 View commit details
    Browse the repository at this point in the history

  15. Fixes

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    71c5765 View commit details
    Browse the repository at this point in the history

  16. Update to new EIP format

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    0c2297b View commit details
    Browse the repository at this point in the history

  17. Assign EIP number

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    0acbfa1 View commit details
    Browse the repository at this point in the history

  18. Clarify encoding of short static byte arrays

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    56f6321 View commit details
    Browse the repository at this point in the history

  19. Removed Solidity changes

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    ae5f668 View commit details
    Browse the repository at this point in the history

  20. Fixup

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    636f0e4 View commit details
    Browse the repository at this point in the history

  21. Fix typos

    @recmo
    recmo committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    15cbcad View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2018

  1. WIP EIP191

    @recmo
    recmo committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    b658f07 View commit details
    Browse the repository at this point in the history

  2. WIP TODO

    @recmo
    recmo committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    0a00916 View commit details
    Browse the repository at this point in the history

  3. WIP Replay attacks

    @recmo
    recmo committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    d3168c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. Fixes the sorted by name example encoding

    @dekz @recmo
    dekz authored and recmo committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    d117b9b View commit details
    Browse the repository at this point in the history

  2. Remove Solidity hash

    @recmo
    recmo committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    5703264 View commit details
    Browse the repository at this point in the history

  3. Added note on replay protection

    @recmo
    recmo committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    121b07a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. Redesign domain separator

    @recmo
    recmo committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    73cfdec View commit details
    Browse the repository at this point in the history

Commits on May 8, 2018

  1. Include images and simple motivation

    @dekz
    dekz committed May 8, 2018
    Configuration menu
    Copy the full SHA
    e2cb963 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into master

    @dekz
    dekz authored May 8, 2018
    Configuration menu
    Copy the full SHA
    780bb68 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2018

  1. Fix up EIP metadata formatting

    @dekz
    dekz committed May 18, 2018
    Configuration menu
    Copy the full SHA
    71d93f9 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from 0xProject/updates/eip-formatting 

    Fix up EIP metadata formatting
    @dekz
    dekz authored May 18, 2018
    Configuration menu
    Copy the full SHA
    7c35e86 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into master

    @dekz
    dekz authored May 18, 2018
    Configuration menu
    Copy the full SHA
    e9387c8 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2018

  1. Merge branch 'master' into master

    @dekz
    dekz authored May 30, 2018
    Configuration menu
    Copy the full SHA
    08c3741 View commit details
    Browse the repository at this point in the history

  2. Add domain separator

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    5c307ce View commit details
    Browse the repository at this point in the history

  3. Remove replay attacks from todo list

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    4f74a93 View commit details
    Browse the repository at this point in the history

  4. Add Jacob Evans to authors

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    6bf149b View commit details
    Browse the repository at this point in the history

  5. Clarify encodeData

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    43b838b View commit details
    Browse the repository at this point in the history

  6. Rename Message example to Mail

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    6d173d9 View commit details
    Browse the repository at this point in the history

  7. Update mock signing screen

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    f5f80fa View commit details
    Browse the repository at this point in the history

  8. Rework EIP712Domain

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    0c57087 View commit details
    Browse the repository at this point in the history

  9. Update Solidity example

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    154834e View commit details
    Browse the repository at this point in the history

  10. Update Javascript example

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    948aa83 View commit details
    Browse the repository at this point in the history

  11. Relocate files

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    bcf5c95 View commit details
    Browse the repository at this point in the history

  12. Rename DomainSeparator to EIP712Domain (fix)

    @recmo
    recmo committed May 30, 2018
    Configuration menu
    Copy the full SHA
    7b85ba3 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2018

  1. Move examples to separate files

    @recmo
    recmo committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    18f0248 View commit details
    Browse the repository at this point in the history

  2. Remove httpOrigin domain parameter

    @recmo
    recmo committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    dcc3b33 View commit details
    Browse the repository at this point in the history

  3. Update JSON-Schema

    @recmo
    recmo committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    d179610 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2018

  1. Add registery of version bytes

    @recmo
    recmo committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    daba29f View commit details
    Browse the repository at this point in the history

  2. Add eip712 to eip191 registery

    @recmo
    recmo committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    452670e View commit details
    Browse the repository at this point in the history

  3. Add requires header

    @recmo
    recmo committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    8efb50a View commit details
    Browse the repository at this point in the history

  4. Set correct language on all snipets

    @recmo
    recmo committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    ec327ac View commit details
    Browse the repository at this point in the history

  5. GitHub highlighting for Solidity files

    @recmo
    recmo committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    bfd3187 View commit details
    Browse the repository at this point in the history

  6. Update Web3 API specification

    @recmo
    recmo committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    0cabeb3 View commit details
    Browse the repository at this point in the history

  7. Use abi.encode where possible

    @recmo
    recmo committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    39f049d View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2018

  1. Update JSON-RPC specification

    @recmo
    recmo committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    f062976 View commit details
    Browse the repository at this point in the history

  2. Asset path repo is ethereums

    @recmo
    recmo committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    81c4295 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2018

  1. Correctly spelling of registry

    @recmo
    recmo committed Jun 9, 2018
    Configuration menu
    Copy the full SHA
    997af5c View commit details
    Browse the repository at this point in the history