Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5725: Move to Last Call #7180

Merged
merged 53 commits into from
Aug 29, 2023
Merged

Update EIP-5725: Move to Last Call #7180

merged 53 commits into from
Aug 29, 2023

Conversation

DeFiFoFum
Copy link
Contributor

@DeFiFoFum DeFiFoFum commented Jun 14, 2023 •
edited
Loading

  • Last Call will last until Friday September 5th, 2023

last call cat

Apegurus and others added 30 commits September 27, 2022 03:09
@Apegurus
Merge pull request #1 from ethereum/master
5188f6f 
Update
@Apegurus
Merge branch 'ethereum:master' into master
89934f8
@Apegurus
chore: Commit draft EIP
70bb638
@Apegurus
chore: ERC to EIP and add EIP number
bfc1e1f
@Apegurus
refactor: EIP Validator changes
1d9961a
@Apegurus
refactor: Relative EIP linking
81feac0
@JorgeAtPaladin
chore: updated author, discussions-to and removed various links
e051390
@JorgeAtPaladin
chore: Moved reference implementation to assets
11e64dc
@JorgeAtPaladin
chore: removed invalid EIP sections
3006271
@Apegurus
Merge pull request #3 from JorgeAtPaladin/draft
48415ba 
Fixed eipw errors
@DeFiFoFum @SamWilsn
refactor: Remove comments from EIP-5725
068abab 
Co-authored-by: Sam Wilson <[email protected]>
@DeFiFoFum
refactor: Update SPDX license to CC0-1.0
3a8ee84
@DeFiFoFum
refactor: Rename IVestingNFT to IERC5725
761abc6
@DeFiFoFum
feat: Add EIP-5725 assets README
f15a541
@DeFiFoFum
Merge branch 'draft' into rebrand/ERC5725
4cb049c
@DeFiFoFum
fix: Links
1118b8d
@DeFiFoFum
fix: Remove EIP-5725 header
f89cd06
@Apegurus @SamWilsn
Apply suggestions from code review
3781d99 
Co-authored-by: Sam Wilson <[email protected]>
@DeFiFoFum
Merge pull request #4 from ApeSwapFinance/rebrand/ERC5725
c62aebe 
Rename IVestingNFT to IERC5725
@DeFiFoFum
refactor: Remove return value from claim()
f84d07c
@DeFiFoFum
fix: EIP-N reference
6b60f17
@Apegurus @SamWilsn
Update EIPS/eip-5725.md
a491393 
Co-authored-by: Sam Wilson <[email protected]>
@Apegurus
refactor: Consistent style and event description
3b5e30a
@Apegurus
refactor: Implement new formatting lint recommendations
23246ed
@DeFiFoFum
refactor: Improve Rationale section
6331c89
@Apegurus
Merge pull request #5 from ApeSwapFinance/dev
aa09fae 
refactor: Consistent style and event description
@Apegurus
fix: MD linter errors
1596f2e
@DeFiFoFum
fix: Return value formatting
b1c8c4e
@DeFiFoFum
Merge branch 'dev' into draft
4a2437a
@DeFiFoFum
Merge pull request #2 from ApeSwapFinance/draft
6ec61de 
chore: Commit draft EIP
@DeFiFoFum DeFiFoFum requested a review from eth-bot as a code owner June 14, 2023 23:37
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Jun 14, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 14, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Jun 14, 2023
@efeDaniels
Copy link

banana-hello

@poojaranjan poojaranjan mentioned this pull request Aug 22, 2023
Closed
11 tasks
SamWilsn
SamWilsn reviewed Aug 22, 2023
View reviewed changes
EIPS/eip-5725.md Outdated Show resolved Hide resolved
@DeFiFoFum
Copy link
Contributor Author

@SamWilsn Thanks so much for the review! 🙏 I have update the last call date to your recommended.

SamWilsn
SamWilsn requested changes Aug 28, 2023
View reviewed changes
assets/eip-5725/contracts/mocks/ERC20Mock.sol Outdated Show resolved Hide resolved
EIPS/eip-5725.md Outdated Show resolved Hide resolved
assets/eip-5725/contracts/reference/LinearVestingNFT.sol Outdated Show resolved Hide resolved
assets/eip-5725/contracts/reference/VestingNFT.sol Outdated Show resolved Hide resolved
@DeFiFoFum
Copy link
Contributor Author

@SamWilsn thx for catching that. 🙏 All comments resolved. 🥳

@eth-bot eth-bot enabled auto-merge (squash) August 29, 2023 14:04
eth-bot
eth-bot approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit d89f7d2 into ethereum:master Aug 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DeFiFoFum @eth-bot @efeDaniels @SamWilsn @Apegurus @JorgeAtPaladin @Elliott-Green