Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Verkle proof verification precompile #7926

Merged
merged 9 commits into from
Nov 10, 2023

Conversation

gballet
Copy link
Member

@gballet gballet commented Oct 26, 2023

No description provided.

@gballet gballet requested a review from eth-bot as a code owner October 26, 2023 09:22
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Oct 26, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 26, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title first draft of the verkle proof verification precompile Add EIP: Verkle proof verification precompile Oct 26, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Oct 26, 2023
@github-actions
Copy link

The commit 4f3d750 (as a parent of 33c62c2) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 26, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 26, 2023
EIPS/eip-7926.md Outdated
@@ -0,0 +1,81 @@
---
eip: 7926
Copy link
Contributor

@xinbenlv xinbenlv Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: 7926
eip: 7545

Assigning number 7545
EIP numbering now follows https://docs.google.com/spreadsheets/d/1f6a4_DPbNOmi4RqlHrDntWfuBjyI8iMWw-r0UwR4JW4/edit#gid=0
Please also update file name

EIPS/eip-7926.md Outdated

## Rationale

Stateless Ethereum relies on proofs using advanced mathematical concepts and tools from a fast-moving area of cryptography. As a result, a soft-fork approach is currently favored in the choice of the proof format: proofs are going to be distributed outside of consensus, and in the future, stateless clients will be able to chose their favorite proof format.
Copy link
Contributor

@xinbenlv xinbenlv Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any proposal of gas cost and analysis to backup that proposed gas cost?

@SamWilsn SamWilsn closed this Oct 26, 2023
@SamWilsn SamWilsn reopened this Oct 26, 2023
@Pandapip1
Copy link
Member

@eth-bot rerun

EIPS/eip-7545.md Outdated Show resolved Hide resolved
EIPS/eip-7545.md Outdated Show resolved Hide resolved
EIPS/eip-7545.md Outdated

A precompiled contract is added at address 0x21, wrapping the stateless ethereum proof verification function.

The precompile requites 4 inputs, tightly encoded:
Copy link
Contributor

@g11tech g11tech Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The precompile requites 4 inputs, tightly encoded:
The precompile requires 4 fixed size inputs concatenated as below:

EIPS/eip-7545.md Outdated Show resolved Hide resolved
EIPS/eip-7545.md Outdated Show resolved Hide resolved
EIPS/eip-7545.md Outdated Show resolved Hide resolved
Co-authored-by: g11tech <[email protected]>
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eth-bot eth-bot enabled auto-merge (squash) November 10, 2023 10:41
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ca09982 into ethereum:master Nov 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants