Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-6493: Use Variant[S] for type safety #7939

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Update EIP-6493: Use Variant[S] for type safety #7939

merged 2 commits into from
Nov 22, 2023

Conversation

etan-status
Copy link
Contributor

No description provided.

@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Oct 29, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 29, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Oct 29, 2023
@github-actions
Copy link

The commit aa86972 (as a parent of 6ecfb64) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 29, 2023
@github-actions github-actions bot added s-final This EIP is Final t-networking and removed w-ci Waiting on CI to pass labels Oct 30, 2023
@eth-bot eth-bot changed the title Update EIP-6493: Use Variant[S] for type safety Update EIP-2718: Use Variant[S] for type safety Nov 6, 2023
@github-actions github-actions bot removed s-final This EIP is Final t-networking labels Nov 6, 2023
@eth-bot eth-bot changed the title Update EIP-2718: Use Variant[S] for type safety Update EIP-6493: Use Variant[S] for type safety Nov 6, 2023
@etan-status
Copy link
Contributor Author

@eth-bot rerun

@eth-bot eth-bot enabled auto-merge (squash) November 22, 2023 11:45
eth-bot
eth-bot approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit d89b671 into ethereum:master Nov 22, 2023
13 of 16 checks passed
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • File assets/eip-6493/convert.py is not an EIP
  • File assets/eip-6493/rlp_types.py is not an EIP
  • File assets/eip-6493/ssz_types.py is not an EIP
  • File assets/eip-6493/tx_hashes.py is not an EIP

@etan-status etan-status deleted the tx-variant branch November 22, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etan-status @eth-bot @eip-automerger @g11tech