Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-1380: fix typo in EIP 1380 #7961

Merged
merged 6 commits into from
May 22, 2024
Merged

Update EIP-1380: fix typo in EIP 1380 #7961

merged 6 commits into from
May 22, 2024

Conversation

WillXing
Copy link
Contributor

@WillXing WillXing commented Nov 9, 2023

fix typo in EIP 1380

@github-actions github-actions bot added c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core labels Nov 9, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 9, 2023 •
edited
Loading

File EIPS/eip-1380.md

Requires 1 more reviewers from @axic, @jacqueswww

@eth-bot eth-bot added the a-review Waiting on author to review label Nov 9, 2023
@eth-bot eth-bot changed the title fix typo in EIP 1380 Update EIP-1380: fix typo in EIP 1380 Nov 9, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 9, 2023
g11tech
g11tech previously approved these changes Nov 9, 2023
View reviewed changes
@g11tech
Copy link
Contributor

g11tech commented Nov 9, 2023

@WillXing there are some linter errors that would also need to be addressed

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 9, 2023
@WillXing WillXing requested a review from g11tech November 9, 2023 22:20
g11tech
g11tech previously approved these changes Nov 10, 2023
View reviewed changes
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 12, 2023
@WillXing
Copy link
Contributor Author

@g11tech the failure in htmlproofer seems unrelated to this PR.

@github-actions GitHub Actions
Copy link

The commit 3a56c82 (as a parent of e2a396d) contains errors.
Please inspect the Run Summary for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 7, 2023
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft s-review This EIP is in Review t-meta t-networking and removed c-new Creates a brand new proposal t-meta t-networking labels Dec 8, 2023
@github-actions github-actions bot removed s-draft This EIP is a Draft s-review This EIP is in Review w-ci Waiting on CI to pass labels Dec 8, 2023
@WillXing WillXing requested a review from g11tech December 8, 2023 09:52
@WillXing
Copy link
Contributor Author

WillXing commented Dec 8, 2023

Sorry for the late fix @g11tech , should be good to go now.

@github-actions github-actions bot removed the w-stale Waiting on activity label Dec 9, 2023
@g11tech
Copy link
Contributor

g11tech commented Dec 11, 2023

seems to require approval from original authors

@WillXing
Copy link
Contributor Author

WillXing commented Jan 7, 2024

Can you kindly approve this PR please. @axic @jacqueswww

@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Apr 20, 2024
@poojaranjan poojaranjan mentioned this pull request May 22, 2024
Closed
14 tasks
@SamWilsn SamWilsn merged commit f1bbc8d into ethereum:master May 22, 2024
9 checks passed
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@WillXing @GAEAlimited
Update EIP-1380: fix typo in EIP 1380 (ethereum#7961)
37de53d 
* fix typo in EIP 1380

* linting fix
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
@WillXing @blacksnow2
Update EIP-1380: fix typo in EIP 1380 (ethereum#7961)
2340e9f 
* fix typo in EIP 1380

* linting fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WillXing @eth-bot @g11tech @SamWilsn