Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: PeerDAS - Peer Data Availability Sampling #8105

Merged
merged 5 commits into from
May 12, 2024

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jan 12, 2024

Add EIP: PeerDAS - Peer Data Availability Sampling draft to get an EIP number.

Once we get an EIP number, we will update the CL specs file path, and then add the circular link to the EIP content later.

@hwwhww hwwhww requested a review from eth-bot as a code owner January 12, 2024 05:47
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-networking labels Jan 12, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 12, 2024

File EIPS/eip-7594.md

Requires 1 more reviewers from @axic, @lightclient, @SamWilsn

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jan 12, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 12, 2024
EIPS/peerdas.md Outdated

Nodes find and maintain a diverse peer set and sample columns from their peers to perform DAS.

A node can reconstruct the entire data matrix if it acquires over 50% of all the columns. If a node has less than 50%, it can request the necessary columns from the peer nodes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>= 50%

Suggested change
A node can reconstruct the entire data matrix if it acquires over 50% of all the columns. If a node has less than 50%, it can request the necessary columns from the peer nodes.
A node can reconstruct the entire data matrix if it acquires at least 50% of all the columns. If a node has less than 50%, it can request the necessary columns from the peer nodes.

EIPS/peerdas.md Outdated
@@ -0,0 +1,52 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
---
eip: 7594

Assigning next sequential EIP/ERC/RIP number.
Numbering changed to sequential from 7500 and is no longer the PR number.

Please also update the filename.

EIPS/peerdas.md Outdated

## Specification

We extend the blobs introduced in EIP-4844 using a one-dimensional erasure coding extension. Each row consists of the blob data combined with its erasure code. It is subdivided into cells, which are the smallest units that can be authenticated with their KZG commitments. Each column, associated with a specific gossip subnet, consists of the cells from all rows for a specific index. Each node is responsible for maintaining and custodying a deterministic set of column subnets and data as a function of their node ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a diagram here would be very illustrative (just a suggestion, so if you already have one please patch it)

@eth-bot eth-bot added the e-review Waiting on editor to review label Jan 18, 2024
---
eip: 7594
title: PeerDAS - Peer Data Availability Sampling
description: Introducing simple DAS utilizing gossip distribution and peer requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Introducing simple DAS utilizing gossip distribution and peer requests
description: Introducing one dimensional DAS utilizing peer gossip, distribution and requests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allows to be more specific for this proposal and in future add a new EIPs for e.g. 2 dimensional peer das

@@ -0,0 +1,52 @@
---
eip: 7594
title: PeerDAS - Peer Data Availability Sampling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: PeerDAS - Peer Data Availability Sampling
title: 1D-PeerDAS - Peer Data Availability Sampling


## Abstract

PeerDAS (Peer Data Availability Sampling) is a networking protocol that allows beacon nodes to perform data availability sampling (DAS) to ensure that blob data has been made available while downloading only a subset of the data. PeerDAS utilizes gossip for distribution, discovery for finding peers of particular data custody, and peer requests for sampling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PeerDAS (Peer Data Availability Sampling) is a networking protocol that allows beacon nodes to perform data availability sampling (DAS) to ensure that blob data has been made available while downloading only a subset of the data. PeerDAS utilizes gossip for distribution, discovery for finding peers of particular data custody, and peer requests for sampling.
PeerDAS (Peer Data Availability Sampling) is a networking protocol that allows beacon nodes to perform data availability sampling (DAS) to ensure that blob data has been made available while downloading only a subset of the data. PeerDAS utilizes gossip for distribution, discovery for finding peers of particular data custody, and peer requests for sampling.
This particular proposal deals with one dimensional DAS

EIPS/eip-7594.md Outdated Show resolved Hide resolved
EIPS/eip-7594.md Outdated Show resolved Hide resolved
@g11tech
Copy link
Contributor

g11tech commented Apr 8, 2024

@hwwhww if you can fix some references and make CI pass, i can probably approve this and get merged in draft status

EIPS/eip-7594.md Outdated Show resolved Hide resolved
EIPS/eip-7594.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented May 2, 2024

The commit ecdda9b (as a parent of 4b8d63d) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 2, 2024
@hwwhww
Copy link
Contributor Author

hwwhww commented May 2, 2024

Hi @g11tech, thank you so much for your reviews and suggestions!

It's better to merge it now and keep the title simple (no 1-D). We can make the new name more descriptive if there is new derivative.

@g11tech
Copy link
Contributor

g11tech commented May 2, 2024

Hi @g11tech, thank you so much for your reviews and suggestions!

It's better to merge it now and keep the title simple (no 1-D). We can make the new name more descriptive if there is new derivative.

EIPs generally can't be edited once final so might not happen, however I am approving this , you can update it anytime before going to final if you would want to

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lightclient lightclient merged commit 7b973be into ethereum:master May 12, 2024
10 checks passed
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
* Add EIP: PeerDAS - Peer Data Availability Sampling

* Rename to EIP-7594 and apply PR suggestion

* Add links

* Update EIPS/eip-7594.md

* Apply suggestions from code review

Co-authored-by: g11tech <[email protected]>

---------

Co-authored-by: g11tech <[email protected]>
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
* Add EIP: PeerDAS - Peer Data Availability Sampling

* Rename to EIP-7594 and apply PR suggestion

* Add links

* Update EIPS/eip-7594.md

* Apply suggestions from code review

Co-authored-by: g11tech <[email protected]>

---------

Co-authored-by: g11tech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants