Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Optimize EOA EXTCODEHASH #8261

Merged
merged 15 commits into from
Aug 3, 2024
Merged

Add EIP: Optimize EOA EXTCODEHASH #8261

merged 15 commits into from
Aug 3, 2024
+104 −0

Conversation

ZWJKFLC
Copy link
Contributor

@ZWJKFLC ZWJKFLC commented Feb 26, 2024

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Feb 26, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 26, 2024 •
edited
Loading

✅ All reviewers have approved.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 26, 2024
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Feb 26, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 26, 2024
abcoathup
abcoathup reviewed Feb 27, 2024
View reviewed changes
EIPS/eip-8261.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed Feb 27, 2024
View reviewed changes
EIPS/eip-8261.md Outdated Show resolved Hide resolved
gaudren
gaudren suggested changes Feb 27, 2024
View reviewed changes
Copy link

@gaudren gaudren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your proposal is a bit hard to understand, you may want to have another person familiar with the subject look over it.

EIPS/eip-7637.md Outdated Show resolved Hide resolved
EIPS/eip-7637.md Outdated Show resolved Hide resolved
EIPS/eip-7637.md Show resolved Hide resolved
EIPS/eip-7637.md Outdated Show resolved Hide resolved
EIPS/eip-7637.md Outdated Show resolved Hide resolved
EIPS/eip-7637.md Outdated Show resolved Hide resolved
EIPS/eip-7637.md Outdated Show resolved Hide resolved
EIPS/eip-7637.md Show resolved Hide resolved
EIPS/eip-7637.md Outdated Show resolved Hide resolved
EIPS/eip-7637.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 28, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 28, 2024
@ZWJKFLC
Copy link
Contributor Author

ZWJKFLC commented Feb 29, 2024

@gaudren @abcoathup

@abcoathup
Copy link
Contributor

@ZWJKFLC need an EIP editor to review (which I am not)

@ZWJKFLC
Copy link
Contributor Author

ZWJKFLC commented Feb 29, 2024

@axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

gaudren
gaudren reviewed Mar 8, 2024
View reviewed changes
Copy link

@gaudren gaudren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you would like to discuss this proposal with someone, @SamWilsn does a biweekly office hour call. The next one is on 03/19/2024 at 11am (ET).

EIPS/eip-7637.md Outdated Show resolved Hide resolved
EIPS/eip-7637.md Show resolved Hide resolved
EIPS/eip-7637.md Show resolved Hide resolved
EIPS/eip-7637.md Show resolved Hide resolved
EIPS/eip-7637.md Show resolved Hide resolved
EIPS/eip-7637.md Show resolved Hide resolved
EIPS/eip-7637.md Show resolved Hide resolved
EIPS/eip-7637.md Show resolved Hide resolved
g11tech
g11tech reviewed Apr 16, 2024
View reviewed changes
EIPS/eip-7637.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label May 29, 2024
g11tech
g11tech reviewed Jun 11, 2024
View reviewed changes
EIPS/eip-7637.md Outdated Show resolved Hide resolved
g11tech
g11tech reviewed Jun 11, 2024
View reviewed changes
EIPS/eip-7637.md Outdated Show resolved Hide resolved
g11tech
g11tech reviewed Jun 11, 2024
View reviewed changes
EIPS/eip-7637.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-stale Waiting on activity label Jun 12, 2024
ZWJKFLC and others added 2 commits June 12, 2024 09:42
@eth-bot eth-bot changed the title Add EIP: EXTCODEHASH optimize Add EIP: Optimize EOA EXTCODEHASH Jun 12, 2024
@github-actions GitHub Actions
Copy link

The commit c756abb (as a parent of d67cee6) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jun 12, 2024
g11tech
g11tech reviewed Jun 19, 2024
View reviewed changes
EIPS/eip-7637.md Outdated Show resolved Hide resolved
@ZWJKFLC @g11tech
Update EIPS/eip-7637.md
07aa3ac 
Fix code logic

Co-authored-by: g11tech <[email protected]>
@poojaranjan poojaranjan mentioned this pull request Jul 3, 2024
Closed
18 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jul 4, 2024
@ZWJKFLC
Copy link
Contributor Author

ZWJKFLC commented Jul 21, 2024

Waiting

@github-actions github-actions bot removed the w-stale Waiting on activity label Jul 22, 2024
g11tech
g11tech approved these changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for draft though language would need to be sharpened and iterated upon if moved to review

@eth-bot eth-bot enabled auto-merge (squash) August 3, 2024 16:12
eth-bot
eth-bot approved these changes Aug 3, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 46f229a into ethereum:master Aug 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@gaudren gaudren gaudren requested changes

@Jaca777 Jaca777 Jaca777 left review comments

@g11tech g11tech g11tech approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZWJKFLC @eth-bot @abcoathup @g11tech @gaudren @Jaca777