Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Transaction Revert Protection #8267

Closed
wants to merge 12 commits into from

Conversation

josephpoon
Copy link

@josephpoon josephpoon commented Feb 29, 2024

Proposal to modify the Ethereum consensus for an opt-in transaction flag to define reverted transactions as invalid (cannot be included in a block).

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Feb 29, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 29, 2024

File EIPS/eip-7640.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Feb 29, 2024
@eth-bot eth-bot changed the title Add EIP: Tranasction Revert Protection Add EIP: Transaction Revert Protection Feb 29, 2024
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Feb 29, 2024
EIP-4337 to ERC-4337
Preamble add EIP
Preamble over 80-columns for description/author for validation
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 29, 2024
Copy link

The commit 5a72142 (as a parent of 75e0e5a) contains errors.
Please inspect the Run Summary for details.

josephpoon and others added 2 commits February 29, 2024 16:07
Add EIP number

Co-authored-by: Andrew B Coathup <[email protected]>
Fix discussions-to link (rename)

Co-authored-by: Andrew B Coathup <[email protected]>
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 29, 2024
Comment on lines +28 to +30
`0x05 || rlp([revert_protect, chain_id, nonce, max_priority_fee_per_gas,
max_fee_per_gas, gas_limit, destination, amount, data, access_list,
signature_y_parity, signature_r, signature_s])`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a bit too technical to add in the Abstract. Might be better to move it to Specification.

For example, an alternate p2p mempool strictly for `revert_protect` could be
constructed where only 100 messages per second can be sent prioritized by the
amount of ETH staked with a socially agreed timeout for these transactions
(e.g. 10 minutes). More exotic constructions can constructed via accounting of
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(e.g. 10 minutes). More exotic constructions can constructed via accounting of
(e.g. 10 minutes). More exotic constructions can be assembled via accounting of

Might have missed a word.

Copy link

github-actions bot commented Jun 2, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jun 2, 2024
@HoangTranMap
Copy link

HoangTranMap commented Jun 2, 2024 via email

@github-actions github-actions bot removed the w-stale Waiting on activity label Jun 3, 2024
@g11tech
Copy link
Contributor

g11tech commented Jun 11, 2024

some unaddressed comments

state of the network.

We introduce a new [EIP-2718](./eip-2718.md) transaction type, with the format
`0x05 || rlp([revert_protect, chain_id, nonce, max_priority_fee_per_gas,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transaction type should be left TBD and mentioned here as a parameter specified in a table as TBD

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jun 26, 2024
Copy link

github-actions bot commented Aug 7, 2024

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Aug 7, 2024
Copy link

@lucentlabz lucentlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants