Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7044: Move to Final #8320

Closed
wants to merge 2 commits into from
Closed

Conversation

dapplion
Copy link
Contributor

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@dapplion dapplion requested a review from eth-bot as a code owner March 14, 2024 23:53
@github-actions github-actions bot added c-status Changes a proposal's status s-final This EIP is Final t-core labels Mar 14, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 14, 2024

File EIPS/eip-7044.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

@eth-bot eth-bot added the e-review Waiting on editor to review label Mar 14, 2024
@eth-bot eth-bot changed the title Move EIP-7044 to Final Update EIP-7044: Move to Final Mar 14, 2024
Copy link

The commit 1f0aa23 (as a parent of 5b8a909) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Mar 15, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Mar 18, 2024
Copy link
Contributor

@poojaranjan poojaranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to update the "Test Cases" Comment.
Something as "Test cases are available within the standard Consensus Layer tests."

@timbeiko
Copy link
Contributor

+1 @dapplion

@timbeiko timbeiko mentioned this pull request Mar 19, 2024
12 tasks
@timbeiko
Copy link
Contributor

@dapplion I did the change in #8345

@dapplion
Copy link
Contributor Author

Closing for #8345

@dapplion dapplion closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-final This EIP is Final t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants