Update EIP-7547: Change modification to payload attribute SSE event #8324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
EIPS/eip-7547.md
Outdated
| @@ -126,7 +126,7 @@ class BeaconBlockBody(Container): | |||
|
|
|||
| **Builder and API spec:** | |||
There was a problem hiding this comment.
Feels odd for the EIP to reference a builder API, given that it is an element outside of the protocol. As I'm not well-versed in the EIP process, is it common for such external to be mentioned?
Additionally, regarding the endpoint modification, builder could just monitor the inclusion list through the gossip network so no additional modification of end point is required.
There was a problem hiding this comment.
Okay; I've updated the PR to remove the offending entry.
terencechain
approved these changes
Mar 16, 2024
eth-bot
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change so that the
payload_attributesSSE event output includes the inclusion list summary.(I believe that this is what is meant, feel free to close this if not.)