Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: add status anchors #8569

Closed
wants to merge 1 commit into from
Closed

Conversation

hanniabu
Copy link

@hanniabu hanniabu commented May 17, 2024

This adds status anchor links to the top of the page as can be seen here: https://i.imgur.com/vi2rL3I.png

Unlike in the image, this PR will only add anchor link if there are EIPs with that status (the image shows "Living" when it shouldn't)

@hanniabu hanniabu requested a review from eth-bot as a code owner May 17, 2024 01:30
@eth-bot
Copy link
Collaborator

eth-bot commented May 17, 2024

File _includes/eiptable.html

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label May 17, 2024
@eth-bot eth-bot changed the title add status anchors Website: add status anchors May 17, 2024
@hanniabu
Copy link
Author

hanniabu commented Jun 3, 2024

bump

Copy link

github-actions bot commented Aug 9, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 9, 2024
@hanniabu
Copy link
Author

hanniabu commented Aug 9, 2024

This PR is ready for review

@github-actions github-actions bot removed the w-stale Waiting on activity label Aug 10, 2024
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@lightclient
Copy link
Member

I think the site needs refresh in general. I would rather not update things piecemeal. This snippet also doesn't show the similar looking navbar for categories. Overall feels like it clutters the interface more than it adds value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants