-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Read BLOCKHASH from storage and update cost #8578
Merged
eth-bot
merged 36 commits into
ethereum:master
from
gabrocheleau:eip/verkle-blockhash-ring-buffer
May 29, 2024
Merged
Add EIP: Read BLOCKHASH from storage and update cost #8578
eth-bot
merged 36 commits into
ethereum:master
from
gabrocheleau:eip/verkle-blockhash-ring-buffer
May 29, 2024
+101
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
Creates a brand new proposal
s-draft
This EIP is a Draft
t-core
labels
May 18, 2024
✅ All reviewers have approved. |
eth-bot
added
e-consensus
Waiting on editor consensus
e-review
Waiting on editor to review
labels
May 18, 2024
shemnon
reviewed
May 18, 2024
JakubPawlukiewicz
approved these changes
May 18, 2024
abcoathup
reviewed
May 20, 2024
abcoathup
reviewed
May 20, 2024
gabrocheleau
changed the title
Add EIP: Adjust the BLOCKHASH opcode to read from storage and update its gas cost
EIP-7709: Adjust the BLOCKHASH opcode to read from storage and update its gas cost
May 20, 2024
The commit 38d94e2 (as a parent of e373909) contains errors. |
gabrocheleau
changed the title
EIP-7709: Adjust the BLOCKHASH opcode to read from storage and update its gas cost
EIP-7709: Read BLOCKHASH from storage and update gas cost
May 20, 2024
eth-bot
changed the title
EIP-7709: Read BLOCKHASH from storage and update gas cost
Add EIP: Adjust the BLOCKHASH opcode to read from storage and update its gas cost
May 20, 2024
eth-bot
changed the title
Add EIP: Adjust the BLOCKHASH opcode to read from storage and update its gas cost
Add EIP: Read BLOCKHASH from storage and update gas cost
May 20, 2024
gabrocheleau
changed the title
Add EIP: Read BLOCKHASH from storage and update gas cost
EIP-7709: Read BLOCKHASH from storage and adjust gas cost
May 20, 2024
eth-bot
changed the title
EIP-7709: Read BLOCKHASH from storage and adjust gas cost
Add EIP: Read BLOCKHASH from storage and update gas cost
May 20, 2024
eth-bot
changed the title
Add EIP: Read BLOCKHASH from storage and update gas cost
Add EIP: Read BLOCKHASH from storage and update cost
May 20, 2024
gabrocheleau
commented
May 27, 2024
Co-authored-by: Gabriel Rocheleau <[email protected]>
gabrocheleau
commented
May 27, 2024
gabrocheleau
commented
May 27, 2024
gabrocheleau
commented
May 27, 2024
gabrocheleau
commented
May 27, 2024
gabrocheleau
commented
May 27, 2024
gabrocheleau
commented
May 27, 2024
gballet
reviewed
May 28, 2024
Co-authored-by: Guillaume Ballet <[email protected]>
g11tech
reviewed
May 28, 2024
g11tech
reviewed
May 28, 2024
hi okayĐược gửi từ iPhone của tôiVào ngày 29 thg 5, 2024, lúc 03:20, g11tech ***@***.***> đã viết:
@g11tech commented on this pull request.
In EIPS/eip-7709.md:
+* at genesis for testnets/devnets where this EIP could also be activated at genesis
+
+The current proposal is to activate this EIP with Verkle to allow for stateless execution of the block.
+
+### Gas costs
+
+As described above, if the `arg` to be resolved is within the correct window, the corresponding `SLOAD` charges and accesses are to be applied for the slot `arg % HISTORY_SERVE_WINDOW`. Note that the `HISTORY_SERVE_WINDOW` and `BLOCKHASH_SERVE_WINDOW` are different.
+
+### System contract
+
+Even if the clients choose to resolve `BLOCKHASH` through system call to [EIP-2935](./eip-2935.md) contract, the gas cost for the system code execution (and also the code witnesses if Verkle activated) is not applied. Only the effect of `SLOAD` is applied as described above.
+
+## Rationale
+
+* The reason behind the updated gas cost is to match the real operation, which is equivalent to an `SLOAD`.
+* The [EIP-2935](./eip-2935.md) system contract execution charges (and accesses) are not applied to keep the gas low and to keep things simple for clients which choose to resolve `BLOCKHASH` in other ways (directly or though memory/maintained history)
i think this addresses it:
..re not applied to keep the gas low and to keep things simple for clients which choose to resolve BLOCKHASH in other ways (directly or though memory/maintained history)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
g11tech
approved these changes
May 29, 2024
eth-bot
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c-new
Creates a brand new proposal
e-consensus
Waiting on editor consensus
e-review
Waiting on editor to review
s-draft
This EIP is a Draft
t-core
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This EIP extracts the following verkle-specific behavior into a separate EIP to be included in a subsequent hard-fork (the verkle hard fork).
Changes
Links