Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-2935: Move to Review #8652

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

timbeiko
Copy link
Contributor

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@timbeiko timbeiko marked this pull request as ready for review June 12, 2024 15:27
@timbeiko timbeiko requested a review from eth-bot as a code owner June 12, 2024 15:27
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-core labels Jun 12, 2024
@timbeiko timbeiko mentioned this pull request Jun 12, 2024
10 tasks
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 12, 2024

File EIPS/eip-2935.md

Requires 1 more reviewers from @g11tech, @gballet, @jochem-brouwer, @jsign, @tanishqjasoria, @tkstanczak, @vbuterin

@eth-bot eth-bot added the a-review Waiting on author to review label Jun 12, 2024
@eth-bot eth-bot changed the title Update eip-2935.md Update EIP-2935: Move to Review Jun 12, 2024
Copy link

The commit be2a444 (as a parent of 3c1113f) contains errors.
Please inspect the Run Summary for details.

lightclient
lightclient previously approved these changes Jun 17, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 17, 2024
@lightclient lightclient merged commit 674813f into ethereum:master Jun 17, 2024
10 of 11 checks passed
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
* Update eip-2935.md

* 2935: rm link to 210

---------

Co-authored-by: lightclient <[email protected]>
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
* Update eip-2935.md

* 2935: rm link to 210

---------

Co-authored-by: lightclient <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-status Changes a proposal's status s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants