Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-2718: Update eip-2718.md #8664

Closed
wants to merge 1 commit into from

Conversation

athevinha
Copy link

Update words

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Update words
@athevinha athevinha requested a review from eth-bot as a code owner June 13, 2024 04:09
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Jun 13, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 13, 2024

File EIPS/eip-2718.md

Requires 1 more reviewers from @MicahZoltu
Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jun 13, 2024
@eth-bot eth-bot changed the title Update eip-2718.md Update EIP-2718: Update eip-2718.md Jun 13, 2024
Copy link

The commit 948d221 (as a parent of 4bd3de8) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 13, 2024
@MicahZoltu
Copy link
Contributor

This looks like a spam PR, recommend closing unless @athevinha wants to try to defend the changes as being meaningful/important.

@Scamreno
Copy link

Scamreno commented Jun 15, 2024 via email

@Scamreno
Copy link

Scamreno commented Jun 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-core w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants