Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7620: Remove initcode/runtime container definitions #8693

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update EIP-7620: Remove initcode/runtime container definitions #8693

merged 1 commit into from
Jul 2, 2024

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Jun 26, 2024

Align with ipsilon/eof#136. Justification of the removal of definitions (from the Megaspec PR):

proposed removing the "initcode container" and "runtime container" definitions, as I think they are unwieldy and suggest a particular implementation (the so-called inside-out determination of container kind). Also, these definitions cross paths with those used in the context of initcontainer_index and deploy_container_index of opcodes

The Megaspec PR isn't yet merged, so if anyone feels strongly about keeping the definitions in, please let know

@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Jun 26, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 26, 2024 •
edited
Loading

✅ All reviewers have approved.

@pdobacz pdobacz marked this pull request as ready for review July 1, 2024 11:27
@pdobacz pdobacz requested a review from eth-bot as a code owner July 1, 2024 11:27
@pdobacz pdobacz closed this Jul 2, 2024
@pdobacz pdobacz reopened this Jul 2, 2024
@eth-bot eth-bot enabled auto-merge (squash) July 2, 2024 15:32
eth-bot
eth-bot approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ff544c1 into ethereum:master Jul 2, 2024
24 checks passed
@pdobacz pdobacz deleted the update7620 branch July 2, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdobacz @eth-bot