Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: EVM Modular Arithmetic Extensions #8743

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

jwasinger
Copy link
Contributor

No description provided.

@jwasinger jwasinger requested a review from eth-bot as a code owner July 21, 2024 07:21
@jwasinger jwasinger changed the title add eip-x: EVM Modular Arithmetic Extensions add eip-5743: EVM Modular Arithmetic Extensions Jul 21, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 21, 2024

File EIPS/eip-7747.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jul 21, 2024
@eth-bot eth-bot changed the title add eip-5743: EVM Modular Arithmetic Extensions Add EIP: EVM Modular Arithmetic Extensions Jul 21, 2024
@jwasinger jwasinger changed the title Add EIP: EVM Modular Arithmetic Extensions Add EIP 8743: EVM Modular Arithmetic Extensions Jul 21, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 21, 2024
@eth-bot eth-bot changed the title Add EIP 8743: EVM Modular Arithmetic Extensions Add EIP: EVM Modular Arithmetic Extensions Jul 21, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 21, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 21, 2024
EIPS/eip-8743.md Outdated
@@ -0,0 +1,228 @@
---
eip: 8743
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: 8743
eip: 7747

Assigning next sequential EIP/ERC/RIP number. Numbers are no longer the issue number.

Please also update the filename.

EIPS/eip-8743.md Outdated
eip: 8743
title: EVM Modular Arithmetic Extensions
status: Draft
type: standards track
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type: standards track
type: Standards Track

EIPS/eip-8743.md Outdated
title: EVM Modular Arithmetic Extensions
status: Draft
type: standards track
author: Jared Wasinger <@jwasinger>, Alex Beregszaszi (@axic)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
author: Jared Wasinger <@jwasinger>, Alex Beregszaszi (@axic)
author: Jared Wasinger (@jwasinger), Alex Beregszaszi (@axic)

EIPS/eip-8743.md Outdated
status: Draft
type: standards track
author: Jared Wasinger <@jwasinger>, Alex Beregszaszi (@axic)
discussions-to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
discussions-to:
discussions-to: https://ethereum-magicians.org/t/eip-7747-evm-modular-arithmetic-extensions/20608

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 22, 2024
@eth-bot eth-bot enabled auto-merge (squash) July 22, 2024 04:11
eth-bot
eth-bot previously approved these changes Jul 22, 2024
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled July 22, 2024 04:16

Head branch was pushed to by a user without write access

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 22, 2024
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jul 22, 2024
Copy link
Contributor

@mratsim mratsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re serialization: I think padding for example to next multiple of 32 bytes should be mentioned.

EIPS/eip-7747.md Outdated Show resolved Hide resolved
EIPS/eip-7747.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jul 22, 2024
Copy link

The commit fe67dac (as a parent of f50981c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus e-review Waiting on editor to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants