Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-6800: Clarify BASIC_DATA layout and update naming #8753

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

jsign
Copy link
Contributor

@jsign jsign commented Jul 23, 2024

This PR proposes:

  • Updates the name of the code hash field to be aligned with the latest EIP-4762.
  • Clarify that packing in BASIC_DATA is done using big-endian. This is required for one of the reserved bytes to extend code_size to 4 bytes in the future.

Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 23, 2024

✅ All reviewers have approved.

@eth-bot eth-bot changed the title EIP-6800: Clarify BASIC_DATA layout and update naming Update EIP-6800: Clarify BASIC_DATA layout and update naming Jul 23, 2024
EIPS/eip-6800.md Outdated Show resolved Hide resolved
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign jsign marked this pull request as ready for review July 24, 2024 13:12
@jsign jsign requested a review from eth-bot as a code owner July 24, 2024 13:12
@eth-bot eth-bot enabled auto-merge (squash) July 24, 2024 13:57
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit d46092b into ethereum:master Jul 24, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants