Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7702: fix delegation designator prefix in Abstract #8755

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jul 23, 2024

No description provided.

@gumb0 gumb0 requested a review from eth-bot as a code owner July 23, 2024 18:07
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 23, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Jul 23, 2024
@@ -13,7 +13,7 @@ requires: 2718, 2929, 2930, 3541, 3607

## Abstract

Add a new transaction type that adds a list of `[chain_id, address, nonce, y_parity, r, s]` authorization tuples. For each tuple, write a delegation designator `(0xef0000 ++ address)` to the signing account's code. All code reading operations must load the code pointed to by the designator.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is a typo, as Specification has 0xef0100

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should also not be 0xef0000, since by EOF terminology this means "EOF v0", which is described in the EOF EIPs as "legacy contracts" (the EOF v0), so it should definitely be something else (0xef0100 ++ address) would be fine, can also ditch the 00 I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing 00 is for versioning I believe

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, that's fine and actually a great idea.

@eth-bot eth-bot enabled auto-merge (squash) July 26, 2024 17:39
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit f798716 into ethereum:master Jul 26, 2024
13 of 14 checks passed
@gumb0 gumb0 deleted the fix-7702-abstract branch July 29, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants