Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5792: multi-chain wallet_sendCalls #8771

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

pedrouid
Copy link
Contributor

@pedrouid pedrouid commented Jul 29, 2024

Changes proposed:

  • move chainId from top-level to call-level
  • add comment on atomicBatch regarding multi-chain

@pedrouid pedrouid requested a review from eth-bot as a code owner July 29, 2024 15:51
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 29, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Jul 29, 2024
@eth-bot eth-bot changed the title Update eip-5792.md Update EIP-5792: Update eip-5792.md Jul 29, 2024
@pedrouid pedrouid changed the title Update EIP-5792: Update eip-5792.md Update EIP-5792: multi-chain wallet_sendCalls Jul 29, 2024
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-interface labels Jul 30, 2024
* MUST send the calls on the same chain identified by the request's `chainId` property
* MUST send the calls in the order specified in the request
* MUST send the calls on the same chain identified by the call's `chainId` property
* MUST NOT await for any calls to be finalized to complete the batch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why you think we should enforce this? I'd expect this to be up to the wallet, until we have the other capability we talked about which would enforce waiting for calls to be mined across chains.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that we would enforce the behavior to always be "parallel" by default

So the new capability would be "sequential" if available

But my take is that either way it should be deterministic by the spec rather than wallet-dependent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm just seeing this. I do feel like generally order matters to devs, but trying to sequence multi chain calls is probably too difficult. Too hard to know when the output of one will land on the other chain, if I am, say, funding my account on chain A from chain B

EIPS/eip-5792.md Outdated Show resolved Hide resolved
@eth-bot eth-bot enabled auto-merge (squash) August 7, 2024 16:50
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants