Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-155: Adding ChainID 0 to increase awareness for EOA registration #8789

Closed
wants to merge 1 commit into from

Conversation

GriffGreen
Copy link

See https://github.com/ChainAgnostic/namespaces/blob/main/eip155/caip10.md for context

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Aug 6, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 6, 2024

File EIPS/eip-155.md

Requires 1 more reviewers from @vbuterin
Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Aug 6, 2024
@eth-bot eth-bot changed the title Adding ChainID 0 to increase awareness for EOA registration Update EIP-155: Adding ChainID 0 to increase awareness for EOA registration Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

The commit 0bce759 (as a parent of 05c8b9e) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Aug 6, 2024
@lightclient
Copy link
Member

Chain id 0 isn't technically a thing. If you were to fill CHAIN_ID in with 0 in this EIP the tx would be rejected because no networks have a chain id of 0 (actual v values ends up being 35 or 36 depending on parity).

@lightclient lightclient closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-core w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants