Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7702: Switch order of authority warm access #8790

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

rakita
Copy link
Contributor

@rakita rakita commented Aug 7, 2024

Small change, it inserts step 8. Add authority to accessed_addresses (as defined in [EIP-2929](./eip-2929.md).) . to become step 3. (Before nonce and bytecode checks)

This is a better order as we load the account first and add authority to the access list before checking if the nonce is equal or if acc is empty/delegated.

@rakita rakita requested a review from eth-bot as a code owner August 7, 2024 14:52
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Aug 7, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 7, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Aug 7, 2024
@eth-bot eth-bot changed the title chore(EIP-7702): Switch order of authority warm access Update EIP-7702: Switch order of authority warm access Aug 7, 2024
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eth-bot eth-bot enabled auto-merge (squash) August 7, 2024 22:35
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 2684d6e into ethereum:master Aug 7, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants