Add EIP: EOF/EVM Trace Specification #8799
Conversation
Expand EIP-3155 to include features for EOF.
github-actions
bot
added
c-new
|
✅ All reviewers have approved. |
eth-bot
added
e-consensus
eth-bot
changed the title
|
The commit 8d96f07 (as a parent of 93e6bb9) contains errors. |
github-actions
bot
added
w-ci
| @@ -154,7 +155,7 @@ This is the trace output from the Ethereum Execution Specification Test from one | |||
| {"pc":13,"op":90,"gas":"0x2fa9e66","gasCost":"0x2","memSize":0,"stack":["0x0","0x0","0x0","0x0","0x0","0x1000"],"depth":1,"refund":0,"opName":"GAS"} | |||
| {"pc":14,"op":241,"gas":"0x2fa9e64","gasCost":"0x2eeb414","memSize":0,"stack":["0x0","0x0","0x0","0x0","0x0","0x1000","0x2fa9e64"],"depth":1,"refund":0,"opName":"CALL"} | |||
| {"pc":0,"section":0,"op":227,"immediate":"0x0001","gas":"0x2eea9ec","gasCost":"0x5","memSize":0,"stack":[],"depth":2,"refund":0,"opName":"CALLF"} | |||
There was a problem hiding this comment.
Ah interesting, I just noticed: so if functionDepth is 0 it is omitted in this trace. I think functionDepth 0 should be added here? Also to the STOP operation.
There was a problem hiding this comment.
functionDepth is optional when zero. I'll add it to the spec. Generally empty/zero/zero length is an optional member. Attempting to reduce repetition.
| - The client MUST NOT output multiple lines for the same operation execution. | ||
| - The client MUST NOT output a line for the `STOP` operation if an error occurred, or if the contract runs out of instructions. | ||
|
|
||
| Each object contains the following members. |
There was a problem hiding this comment.
Since these are JSON objects, would you consider using JSON Schema to describe the format? The schema could also be included as an asset instead.
There was a problem hiding this comment.
This is an update of 3155, not a reboot. Using JSON Schema would not guarantee backwards compatability with existing clients, which is a top priority.
There was a problem hiding this comment.
You can define only the properties introduced in this proposal and leave the rest undefined. For example:
{
"$schema": "https://json-schema.org/draft/2019-09/schema",
"type": "object",
"properties": {
"section": {
"type": "number"
},
"immediate": {
"$ref": "#/$defs/hex-string"
},
"functionDepth": {
"type": "number"
}
},
"$defs": {
"hex-string": {
"type": "string",
"pattern": "^0x[0-9A-Fa-f]*$",
}
}
}
EIPS/eip-7756.md
Outdated
|
|
||
| ## Test Cases | ||
|
|
||
| This is the trace output from the Ethereum Execution Specification Test from one of the parameterized executions of the test `test_eof_functions_contract_call_succeed` in `prague/eip7692_eof_v1/eip3540_eof_v1/test_execution_function.py`. Memory and return data are disabled. |
There was a problem hiding this comment.
You can link to tests directly as long as it matches these regexes:
Lines 151 to 152 in 46e7845
| - The client MUST NOT output multiple lines for the same operation execution. | ||
| - The client MUST NOT output a line for the `STOP` operation if an error occurred, or if the contract runs out of instructions. | ||
|
|
||
| Each object contains the following members. |
There was a problem hiding this comment.
This is an update of 3155, not a reboot. Using JSON Schema would not guarantee backwards compatability with existing clients, which is a top priority.
Expand EIP-3155 to include features for EOF.