Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7251: typo in the code #8815

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update EIP-7251: typo in the code #8815

merged 1 commit into from
Aug 20, 2024

Conversation

NikZak
Copy link
Contributor

@NikZak NikZak commented Aug 20, 2024

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@NikZak NikZak requested a review from eth-bot as a code owner August 20, 2024 08:07
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Aug 20, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 20, 2024 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Aug 20, 2024
@eth-bot eth-bot changed the title typo in the code Update EIP-7251: typo in the code Aug 20, 2024
@NikZak
Copy link
Contributor Author

NikZak commented Aug 20, 2024

@eth-bot rerun

mkalinin
mkalinin approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eth-bot eth-bot enabled auto-merge (squash) August 20, 2024 11:55
eth-bot
eth-bot approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit bc91716 into ethereum:master Aug 20, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@onbjerg onbjerg onbjerg approved these changes

@mkalinin mkalinin mkalinin approved these changes

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NikZak @eth-bot @mkalinin @onbjerg