Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5792: Move to Review #8834

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

lukasrosario
Copy link
Contributor

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-interface labels Aug 28, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 28, 2024

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update EIP-5792: Move back to review Update EIP-5792: Move to Review Aug 28, 2024
@lukasrosario lukasrosario marked this pull request as ready for review August 28, 2024 20:34
@lukasrosario lukasrosario reopened this Aug 28, 2024
@eth-bot eth-bot enabled auto-merge (squash) August 28, 2024 21:17
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 770f378 into ethereum:master Aug 28, 2024
29 of 30 checks passed
@frangio
Copy link
Contributor

frangio commented Sep 6, 2024

@lukasrosario What is the best place to discuss this EIP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status s-review This EIP is in Review t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants