Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7742: Move to Review #8837

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

ralexstokes
Copy link
Member

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-core labels Aug 29, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 29, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Aug 29, 2024
@eth-bot eth-bot changed the title update EIP-7742 to Review status Update EIP-7742: Move to Review Aug 29, 2024
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the "TBD" and replace with its actual value before moving to review. You can instead remove the whole FORK_TIMESTAMP thing (it's a holdover from ancient EIPs), and just say "after this proposal is activated" or similar.

@ralexstokes
Copy link
Member Author

@SamWilsn done!

Copy link

github-actions bot commented Sep 3, 2024

The commit 9ddf821 (as a parent of bf7955d) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Sep 3, 2024
@g11tech
Copy link
Contributor

g11tech commented Sep 3, 2024

@SamWilsn done!

CI failing

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Sep 4, 2024
@ralexstokes
Copy link
Member Author

@SamWilsn done!

CI failing

@g11tech fixed, thanks!

@eth-bot eth-bot enabled auto-merge (squash) September 4, 2024 17:10
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@lightclient lightclient merged commit a78f470 into ethereum:master Sep 4, 2024
11 checks passed
@ralexstokes ralexstokes deleted the 7742-to-review branch September 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants