Add EIP: GAS2ETH opcode #8980

charles-cooper · 2024-10-20T15:35:22Z

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

Signed-off-by: Pascal Marco Caversaccio <[email protected]>

Amend `GAS2ETH` Proposal

eth-bot · 2024-10-20T15:35:50Z

File `EIPS/eip-7791.md`

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

EIPS/eip-gas_to_eth.md

Co-authored-by: Andrew B Coathup <[email protected]>

github-actions · 2024-10-21T18:20:04Z

The commit 3a58567 (as a parent of 95e214f) contains errors.
Please inspect the Run Summary for details.

jochem-brouwer

Some questions/remarks.

jochem-brouwer · 2024-10-22T14:15:23Z

EIPS/eip-7791.md

+
+- Pops two values from the stack: `addr` then `gas_amount`. If there are fewer than two values on the stack, the calling context should fail with stack underflow.
+- Deducts `gas_amount` from the current calling context.
+- Computes `wei_val` by multiplying `gas_amount` by the current transaction context's `gas_price`.


What is the gas price? Is this the base fee? Or is this the tip? Or is it both?

interesting question, i think it should be the tx gas price which is used to calculate the tx cost in ETH, a la https://github.com/ethereum/execution-specs/blob/98d6ddaaa709a2b7d0cd642f4cfcdadc8c0808e1/src/ethereum/berlin/fork.py#L680.

jochem-brouwer · 2024-10-22T14:16:14Z

EIPS/eip-7791.md

+- If the gas cost of this opcode + `gas_amount` is greater than the available gas in the current calling context, the calling context should fail with "out-of-gas" and any state changes reverted.
+- Pushes `wei_val` onto the stack.
+
+Note that the transfer of `wei_val` to the given account cannot fail. In particular, the destination account code (if any) is not executed, or, if the account does not exist, the balance is still added to the given address `addr`.


There is extra gas cost in CALL if the call sends value and a new address is created in the trie. I think this should be added here as well.

jochem-brouwer · 2024-10-22T14:18:41Z

EIPS/eip-7791.md

+
+The proposed cost of this opcode is similar to the recently proposed `PAY` opcode, but changing the base cost from `9000` to `2400`. That is:
+
+- The base cost of this opcode is `2400`. This is priced so that invoking `GAS2ETH` on a cold account costs the same as a cold `SSTORE`.


SSTORE cold on a storage slot which is currently nonzero changing to another nonzero value costs 5000 gas (if its warm: 2900 gas). I'm not sure how to get 2400.

jochem-brouwer · 2024-10-22T14:19:17Z

EIPS/eip-7791.md

+The proposed cost of this opcode is similar to the recently proposed `PAY` opcode, but changing the base cost from `9000` to `2400`. That is:
+
+- The base cost of this opcode is `2400`. This is priced so that invoking `GAS2ETH` on a cold account costs the same as a cold `SSTORE`.
+- If `addr` is not the zero address, the [EIP-2929](./eip-2929.md) account access costs for `addr` (but NOT the current account) are also incurred: 100 gas for a warm account, 2600 gas for a cold account, and 25000 gas for a new account.


What does the zero address have to do with this? Does this change some behavior of this opcode?

that must be a mistake that slipped in over the course of revisions, will fix

PatrickAlphaC · 2024-10-22T21:55:10Z

This seems like a great idea, but I'm nervous about people abusing this. Why would I, as a protocol developer, ever us msg.value if I can "trick" users into paying me via gas?

g11tech · 2024-10-30T19:49:20Z

EIPS/eip-7791.md

+
+## Test Cases
+
+TBD


TBD should be in html tags so that bot can remind to fill them before moving to revew

add <-- TODO --> tags for EIP bots to notify you to fill them up post draft stage

g11tech · 2024-10-30T19:51:05Z

EIPS/eip-7791.md

+
+## Test Cases
+
+TBD


TBD should be in html tags so that bot can remind to fill them before moving to review

sorry, what html tags?

add <-- TODO --> tags for EIP bots to notify you to fill them up post draft stage

charles-cooper · 2024-10-31T17:18:57Z

This seems like a great idea, but I'm nervous about people abusing this. Why would I, as a protocol developer, ever us msg.value if I can "trick" users into paying me via gas?

i don't think it's a trick -- it's just an alternative way to get compensation. getting compensation via msg.value has some downsides, in particular:

it's less composable - users of your protocol (and it could be called via smart contract) would not know at call-time how much needs to be paid
it's tied to ETH price, whereas gas is tied to blockspace demand

charles-cooper and others added 8 commits August 12, 2023 18:45

being drafting gas_to_eth eip

8ae8e07

add some motivation

a399da1

update pricing

48e0bab

reduce pricing again to mimic sstore

1f4755e

📝 Amend GAS2ETH Proposal

7169abe

Signed-off-by: Pascal Marco Caversaccio <[email protected]>

Merge pull request #1 from pcaversaccio/amend-gas-to-eth

9927a7b

Amend `GAS2ETH` Proposal

update / roll back some wording

9a78029

add author

324ef9b

charles-cooper requested a review from eth-bot as a code owner October 20, 2024 15:35

github-actions bot added the w-ci Waiting on CI to pass label Oct 20, 2024

abcoathup reviewed Oct 21, 2024

View reviewed changes

EIPS/eip-gas_to_eth.md Outdated Show resolved Hide resolved

abcoathup reviewed Oct 21, 2024

View reviewed changes

EIPS/eip-gas_to_eth.md Outdated Show resolved Hide resolved

abcoathup reviewed Oct 21, 2024

View reviewed changes

EIPS/eip-gas_to_eth.md Outdated Show resolved Hide resolved

charles-cooper and others added 2 commits October 21, 2024 07:58

add EIP number

799361d

Co-authored-by: Andrew B Coathup <[email protected]>

add discussions-to link

3f5f76d

Co-authored-by: Andrew B Coathup <[email protected]>

github-actions bot removed the w-ci Waiting on CI to pass label Oct 21, 2024

remove backticks in title

527b729

Co-authored-by: Andrew B Coathup <[email protected]>

github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Oct 21, 2024

eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Oct 21, 2024

eth-bot changed the title ~~GAS2ETH opcode~~ Add EIP: GAS2ETH opcode Oct 21, 2024

github-actions bot added the w-ci Waiting on CI to pass label Oct 21, 2024

move eip md to the numbered file

3a58567

charles-cooper added 2 commits October 21, 2024 17:28

grammar touchups, rewording

d431238

fix lint

23f511e

github-actions bot removed the w-ci Waiting on CI to pass label Oct 21, 2024

jochem-brouwer reviewed Oct 22, 2024

View reviewed changes

remove zero address case

6d84465

poojaranjan mentioned this pull request Oct 29, 2024

EIP Editing Office Hour Meeting 46 ethcatherders/EIPIP#363

Open

58 tasks

g11tech reviewed Oct 30, 2024

View reviewed changes

Setland34 approved these changes Nov 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP: GAS2ETH opcode #8980

Add EIP: GAS2ETH opcode #8980

charles-cooper commented Oct 20, 2024

eth-bot commented Oct 20, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024

jochem-brouwer left a comment

jochem-brouwer Oct 22, 2024

charles-cooper Oct 31, 2024

jochem-brouwer Oct 22, 2024

jochem-brouwer Oct 22, 2024

jochem-brouwer Oct 22, 2024

charles-cooper Oct 22, 2024

PatrickAlphaC commented Oct 22, 2024 •

edited

Loading

g11tech Oct 30, 2024

g11tech Nov 13, 2024

g11tech Oct 30, 2024

charles-cooper Oct 31, 2024

g11tech Nov 13, 2024

charles-cooper commented Oct 31, 2024


		The proposed cost of this opcode is similar to the recently proposed `PAY` opcode, but changing the base cost from `9000` to `2400`. That is:

		- The base cost of this opcode is `2400`. This is priced so that invoking `GAS2ETH` on a cold account costs the same as a cold `SSTORE`.

Add EIP: GAS2ETH opcode #8980

Are you sure you want to change the base?

Add EIP: GAS2ETH opcode #8980

Conversation

charles-cooper commented Oct 20, 2024

eth-bot commented Oct 20, 2024 • edited Loading

File EIPS/eip-7791.md

github-actions bot commented Oct 21, 2024

jochem-brouwer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PatrickAlphaC commented Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charles-cooper commented Oct 31, 2024

eth-bot commented Oct 20, 2024 •

edited

Loading

File `EIPS/eip-7791.md`

PatrickAlphaC commented Oct 22, 2024 •

edited

Loading