Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-1363: Remove non-relative links and unuseful references #214

Closed
wants to merge 3 commits into from
Closed

Update ERC-1363: Remove non-relative links and unuseful references #214

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e96ab4
fix: remove non-relative links and unuseful references
vittominacori Jan 22, 2024
deb93d7
Merge branch 'master' of https://github.com/ethereum/ERCs into fix/re…
vittominacori Apr 10, 2024
9319bc0
Merge branch 'master' of https://github.com/ethereum/ERCs into fix/re…
vittominacori Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ERCS/erc-1363.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---

Check failure on line 1 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble is missing header(s): `description` 

error[preamble-req]: preamble is missing header(s): `description`
--> ERCS/erc-1363.md
 |
 |
 = help: see https://ethereum.github.io/eipw/preamble-req/
eip: 1363
title: Payable Token
author: Vittorio Minacori (@vittominacori)
discussions-to: https://github.com/ethereum/eips/issues/1363

Check failure on line 5 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `discussions-to` should point to a thread on ethereum-magicians.org 

error[preamble-re-discussions-to]: preamble header `discussions-to` should point to a thread on ethereum-magicians.org
 --> ERCS/erc-1363.md:5:16
  |
5 | discussions-to: https://github.com/ethereum/eips/issues/1363
  |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required pattern was not matched
  |
  = info: the pattern in question: `^https://ethereum-magicians.org/t/[^/]+/[0-9]+$`
  = help: see https://ethereum.github.io/eipw/preamble-re-discussions-to/
status: Final
type: Standards Track
category: ERC
Expand All @@ -10,7 +10,7 @@
requires: 20, 165
---

## Simple Summary

Check failure on line 13 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

body has extra section(s) 

error[markdown-order-section]: body has extra section(s)
  --> ERCS/erc-1363.md
   |
13 | ## Simple Summary
   |
   = help: see https://ethereum.github.io/eipw/markdown-order-section/
Defines a token interface for [ERC-20](./eip-20.md) tokens that supports executing recipient code after `transfer` or `transferFrom`, or spender code after `approve`.

## Abstract
Expand Down Expand Up @@ -197,14 +197,14 @@
The choice to use `transferAndCall`, `transferFromAndCall` and `approveAndCall` derives from the [ERC-20](./eip-20.md) naming. They want to highlight that they have the same behaviours of `transfer`, `transferFrom` and `approve` with the addition of a callback on receiver or spender.

## Backwards Compatibility
This proposal has been inspired also by [ERC-223](https://github.com/ethereum/EIPs/issues/223) and [ERC-677](https://github.com/ethereum/EIPs/issues/677) but it uses the [ERC-721](./eip-721.md) approach, so it doesn't override the [ERC-20](./eip-20.md) `transfer` and `transferFrom` methods and defines the interfaces IDs to be implemented maintaining the [ERC-20](./eip-20.md) backwards compatibility.
Unlike other ERC-20 extension proposals, ERC-1363 doesn't override the ERC-20 `transfer` and `transferFrom` methods and defines the interfaces IDs to be implemented maintaining backward compatibility with ERC-20.

## Security Considerations
The `approveAndCall` and `transferFromAndCall` methods can be affected by the same issue of the standard [ERC-20](./eip-20.md) `approve` and `transferFrom` method.
The `approveAndCall` and `transferFromAndCall` methods can be affected by the same issue of the standard ERC-20 `approve` and `transferFrom` method.

Changing an allowance with the `approveAndCall` methods brings the risk that someone may use both the old and the new allowance by unfortunate transaction ordering.

One possible solution to mitigate this race condition is to first reduce the spender's allowance to 0 and set the desired value afterwards ([EIP-20#issuecomment-263524729](https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729)).
One possible solution to mitigate this race condition is to first reduce the spender's allowance to 0 and set the desired value afterwards.

## Copyright
Copyright and related rights waived via [CC0](../LICENSE.md).
Loading