Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Solana Storage Router #390

Open
wants to merge 63 commits into
base: master
Choose a base branch
from

Conversation

sshmatrix
Copy link
Contributor

@sshmatrix sshmatrix commented Apr 18, 2024

The following standard is an extension to the Cross-chain Storage Router Protocol (EIP-7700; #404) introducing storage router for Solana.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Apr 18, 2024

File ERCS/erc-7694.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@github-actions github-actions bot added the w-ci label Apr 18, 2024
@eip-review-bot eip-review-bot changed the title Extension to ERC-5559: External Solana Handler Add ERC: Solana storage handler for CCIP-Write Apr 18, 2024
ERCS/erc-____.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci label Apr 18, 2024
ERCS/erc-7694.md Outdated Show resolved Hide resolved
ERCS/erc-7694.md Outdated Show resolved Hide resolved
@eip-review-bot eip-review-bot changed the title Add ERC: Solana storage handler for CCIP-Write Add ERC: Solana Storage Router May 3, 2024
@github-actions github-actions bot added the w-ci label May 3, 2024
@github-actions github-actions bot added w-ci and removed w-ci labels May 3, 2024
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your specification section mostly goes into detail on marshalling data between Solana and Ethereum. It does not actually explain the mechanism for getting data between chains (or if it does, I've missed it.)

If that's explained in 7700, perhaps adding something like "See EIP-7700 for details on the mechanism for conveying data" would be helpful?

ERCS/erc-7694.md Show resolved Hide resolved
ERCS/erc-7694.md Outdated Show resolved Hide resolved
assets/erc-7694/images/Schema.svg Outdated Show resolved Hide resolved
ERCS/erc-7694.md Outdated Show resolved Hide resolved
assets/erc-7694/fonts/SF-Mono.woff2 Outdated Show resolved Hide resolved
assets/erc-7694/fonts/Spotnik.woff2 Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants