Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-1363: Update text to modern recommendations #403

Conversation

vittominacori
Copy link
Contributor

In order to be more clear and understandable I've updated some text and sections in order to be compliant with the new recommendations.

The content of the ERC was not edited but only rewritten and reorganized in a more clear way (also because of the first version was of 2018).

I've requested these changes in a moment when the EIP repo was migrating and these were rejected. I hope they can be reviewed now that the process is almost completed.

@vittominacori vittominacori changed the title Update text to modern recommendation Update text to modern recommendations Apr 29, 2024
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Apr 29, 2024

File ERCS/erc-1363.md

Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title Update text to modern recommendations Update ERC-1363: Update text to modern recommendations Apr 29, 2024
@vittominacori vittominacori force-pushed the feat/update-texts-to-modern-recommendation branch from 80c2a7a to 3c1ba1c Compare May 7, 2024 07:59
Copy link

github-actions bot commented Jun 4, 2024

The commit 2832025 (as a parent of c8fe90c) contains errors.
Please inspect the Run Summary for details.

@SamWilsn
Copy link
Collaborator

For changes to Final proposals, please ignore eipw (aka "EIP Walidator".) Only make the minimal changes required to clarify the text or fix errors. Anything else will likely get rejected.

@vittominacori
Copy link
Contributor Author

@SamWilsn yes I know but this is simply moving content to the right section as defined by EIP1, removing external links, and adjust some text.

@SamWilsn
Copy link
Collaborator

As decided in ethcatherders/EIPIP#346, we feel this pull request is changing too much for a Final proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants