Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Cache invalidation in ERC-5219 mode Web3 URL #652
base: master
Are you sure you want to change the base?
Add ERC: Cache invalidation in ERC-5219 mode Web3 URL #652
Changes from 12 commits
79d58dd
2d9255f
e709729
392f73a
91c14e5
a641ef1
5a62e60
4109a58
950887f
5245dc4
591aa10
72490e7
586f7f4
5a70147
4ac12c9
bf3eb93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are definitely some security considerations, no? At the very least contracts need to correctly emit cache invalidation events, or stale content could be served.
I bet there are some unpleasant interactions between this and chain reorgs. as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed!
I have added 3 :
web3://
client picking and processing the event.web3://
client must roll back its caching state, or reverted content will be served until the next cache clearing event.The first one is something that conceptually annoys me (even if the
web3://
client is optimizing its logs reading by using streams, it can theorically be missed).So I am thinking about ways for the website to signal to the
web3://
client when fetching a page: "hey please ensure you are up to date with block XXX (because I just made a change on it via a TX)".A HTTP header in the request is an idea, but may be not practical when doing a page change (e.g. in blog post edit page, save tx, then go to blog post page view). Thinking...