Update LLL code in tests to avoid using define-on-use variables

[axic]

This change should generate the exact same bytecode as before.

Fixes #3387.

[axic]

@winsvega can you please review this? It should work with the "strict parser" branch of Solidity.

@zigguratt can you also please double check this?

[zigguratt]

I found a couple more places where i is auto-defined. I don't have commit privileges of course, so I've attached a diff (apparently GitHub doesn't recognize .diff files).

out.diff.txt

[axic]

@zigguratt thank you, added your changes

[chriseth]

@winsvega is this fine from your side?

[chfast]

Does this modify the output tests?

[axic]

@chfast the changed code should output the exact same bytecode and should work with both the current lllc and with this PR: ethereum/solidity#1313.

I just don't have the knowledge (and CPU power) on the testing infrastructure, to run the test generators (fillers?) and the actual tests to verify.

[winsvega]

could we merge this into #3381
eip158 branch ?

[axic]

@winsvega should I push this commit to that branch?

[chriseth]

@winsvega please add the correct transition block number, add the strict lll parser commit by @axic and then merge.

[axic]

@winsvega can you please confirm this doesn't break any tests (with both the stock lllc and the solidity/#1313 PR)?

[axic]

@winsvega @chriseth updated for EIP158

[winsvega]

The tests would be upgraded. I am afraid we will have to repeat this changes to the new general tests