Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registerValidator should allow same timestamp #27

Merged
merged 1 commit into from
Jun 3, 2022
Merged

registerValidator should allow same timestamp #27

merged 1 commit into from
Jun 3, 2022

Conversation

metachris
Copy link
Contributor

@metachris metachris commented May 31, 2022 •
edited by ralexstokes
Loading

fixes #26.

should allow resending previous registrations

@metachris
registerValidator should allow same timestamp
0f1ae52 
should allow resending previous registrations
ralexstokes
ralexstokes approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this simplifies the validator registration flow a lot as upstream nodes in the builder pipeline can just cache the latest one and re-send to any parties that may need it without requiring the validator to start from their end of the flow

@lightclient lightclient merged commit 3f38e6c into ethereum:main Jun 3, 2022
@Ruteri Ruteri mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient approved these changes

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message rejection when timestamps are equal
3 participants
@metachris @ralexstokes @lightclient