WIP: First pass at adding to glossary and readme #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a question about the term co-validator @adiasg, here are some excerpts that I don't think are consistent.
from glossary.md
from ./dvspec/spec.py
In the first example, a co-validator is a single BLS key, in the next two a co-validator is what we have been calling an operator. In the python file, the
CoValidator
class is closer to the BLS key concept.Might I suggest that co-validator is ambiguous, and that maybe the terms
Operator
andDistributed Validator Key Share
are more clear? Or we could keep co-validator to mean key share but I would sayco-validator key
not justco-validator
as is, because most people I have talked to infer co-validator to mean operator/person, not private key. Obviously this is a reflection of the eth2 spec itself considering people don't differentiate between person who runs a validator, a validator client, and a validator key, all of them get ambiguously called validator too.Would like to get your thoughts on this before this PR is ready to merge, as I have only touched the markdown files, and haven't made any changes to the .py files until I've gotten your perspective, and would like to reflect what we pick in both places rather than adding even more inconsistency.