Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow withdrawn EIPs in the requires header #98

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eipw-lint/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,11 @@ pub fn default_lints_enum() -> impl Iterator<Item = (&'static str, DefaultLint<&
prefix: "eip-",
suffix: ".md",
flow: vec![
vec!["Withdrawn"],
vec!["Draft", "Stagnant"],
vec!["Review"],
vec!["Last Call"],
vec!["Final", "Withdrawn", "Living"],
vec!["Final", "Living"],
]
}),
),
Expand Down
6 changes: 6 additions & 0 deletions eipw-lint/tests/eipv/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# To run the eipv tests:

```
cd eipw-lint
cargo test --all --all-features
```
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
status: Final
---
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
status: Last Call
---
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
status: Withdrawn
---
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
error[preamble-requires-status]: preamble header `requires` contains items not stable enough for a `status` of `Review`
--> input.md:11:20
|
11 | requires: 20, 1337, 2048
| ^^^^^ has a less advanced status
|
= help: valid `status` values for this proposal are: `Withdrawn`
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
---
eip: 1
title: A sample proposal
description: This proposal is a sample that should be considered
author: John Doe (@johndoe), Jenny Doe <[email protected]>
discussions-to: https://ethereum-magicians.org/t/hello/1
status: Review
type: Standards Track
category: Core
created: 2020-01-01
requires: 20, 1337, 2048
---

## Abstract

This is the abstract for the EIP.

## Motivation

This is the motivation for the EIP.

## Specification

This is the specification for the EIP.

## Rationale

This is the rationale for the EIP.

## Backwards Compatibility

These are the backwards compatibility concerns for the EIP.

## Test Cases

These are the test cases for the EIP.

## Reference Implementation

This is the implementation for the EIP.

## Security Considerations

These are the security considerations for the EIP.

## Copyright

Copyright and related rights waived via [CC0](../LICENSE.md).
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ error[preamble-requires-status]: preamble header `requires` contains items not s
| ^^^ has a less advanced status
| ^^^^^ has a less advanced status
|
= help: valid `status` values for this proposal are: `Draft`, `Stagnant`
= help: valid `status` values for this proposal are: `Draft`, `Stagnant`, `Withdrawn`
Loading