Fix lack of cleanup for stateful tests #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes part of issues mentioned in #77 |
|
I've given this a sanity inspection to make sure I didn't do anything blatantly dumb and these changes are pretty straight forward so I'm just going to merge them. |
pacrob
added a commit
to pacrob/eth-abi
that referenced
this pull request
Apr 14, 2023
* repin flake8, bump tox to >=4.0.0 as that's where whitelist was deprecated, misc updates
pacrob
added a commit
to pacrob/eth-abi
that referenced
this pull request
Dec 9, 2023
* repin flake8, bump tox to >=4.0.0 as that's where whitelist was deprecated, misc updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Some stateful tests introduced in PR #76 did not cleanup after themselves.
How was it fixed?
Wrapped test code in try/finally blocks to automatically clean up state changes.
Cute Animal Picture