bump keyfile and abi versions, fix new lint errors #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
bump-keyfile-dep
branch
from
a1b2a84 to
d0b4dab
Compare
kclowes
reviewed
Feb 3, 2025
There was a problem hiding this comment.
I could be persuaded otherwise, but I think we should keep this stacked until we're ready to drop py3.8 and jump into a breaking changes cycle across the libraries. It's a small change, but I'm concerned we'll create a dependency hell for users with the eth-keyfile bump. But it looks good otherwise!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth-keyfile v0.9.0was released, so we can now bump its dep here to>=0.9.0.How was it fixed?
Bumped and fixed minor lint errors. Removed the beta from the
eth-abidep too.Closes #305
Todo:
Cute Animal Picture