Update readme for Netlify and NextJS #12041
Conversation
corwintines
requested review from
wackerow,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
corwintines
changed the title
README.md
Outdated
| ``` | ||
|
|
||
| - Open this directory in your favorite text editor / IDE, and see your changes live by visiting `localhost:8000` from your browser | ||
| - Open this directory in your favorite text editor / IDE, and see your changes live by visiting `localhost:3000` from your browser | ||
| - Pro Tip: | ||
| - Explore scripts within `package.json` for more build options | ||
| - Get **faster** local builds by building only one language. E.g. in your `.env` file, set `BUILD_LOCALES=en` to build the content only in English |
There was a problem hiding this comment.
Not a blocker for this PR, but this tip is less helpful now that we use Next.js... it's handy if you're building the site, but doesn't matter for yarn dev since pages are built on-demand.
There was a problem hiding this comment.
Agree. I found it informative though. Perhaps we could clarify that it is faster for production builds (yarn build).
There was a problem hiding this comment.
Changed the wording here to be production
README.md
Outdated
| - Gatsby Cloud (our hosting service for build previews) deploys all PRs to a publicly accessible preview URL, e.g.: | ||
|  | ||
| - _Confirm your GC preview deploy looks & functions as expected_ | ||
| - Netlify (our hosting service for build previews) deploys all PRs to a publicly accessible preview URL, e.g.: |
There was a problem hiding this comment.
...accessible preview URL, e.g.:
@corwintines Did we mean to remove the image here? If so, we should remove the , e.g.: from the end of this line
There was a problem hiding this comment.
I think we should add an image here. Probably this:
There was a problem hiding this comment.
Added this image, thanks @pettinarip!
README.md
Outdated
| - Gatsby Cloud (our hosting service for build previews) deploys all PRs to a publicly accessible preview URL, e.g.: | ||
|  | ||
| - _Confirm your GC preview deploy looks & functions as expected_ | ||
| - Netlify (our hosting service for build previews) deploys all PRs to a publicly accessible preview URL, e.g.: |
There was a problem hiding this comment.
I think we should add an image here. Probably this:
Co-authored-by: Pablo Pettinari <[email protected]>
wackerow
added
documentation 📖
Description
Fixes: #12068