Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storybook): create stories for Logo.tsx #13265

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

tomasgrusz
Copy link
Contributor

@tomasgrusz tomasgrusz commented Jun 27, 2024

  • Move /src/components/Logo.tsx to /src/components/Logo/index.tsx
  • Fix any filepath changes to imports for the Logo component
  • Create story file /src/components/Logo/Logo.stories.tsx
  • Write story testing render of the Logo component in context of use

Related Issue

Create story for Logo component #13067

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2876f53
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/667de7e64810400008c84450
😎 Deploy Preview https://deploy-preview-13265--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 44 (🔴 down 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomasgrusz tomasgrusz changed the title feat: move Logo to its own folder, preparation for stories: test(storybook): create stories for Logo.tsx Jun 27, 2024
@tomasgrusz tomasgrusz marked this pull request as ready for review June 27, 2024 22:31
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 28, 2024
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomasgrusz

@corwintines corwintines merged commit 9491765 into ethereum:dev Sep 2, 2024
9 of 11 checks passed
This was referenced Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants