Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] purple color tokens as primary color #13329

Closed
wants to merge 6 commits into from
Closed

Conversation

nloureiro
Copy link
Contributor

We are working on a big transformation in the style, and this PR is to test:

  • what if we have the "same" primary color? we choose purple

you can follow the color explorations here:
https://www.figma.com/design/NrNxGjBL0Yl1PrNrOT8G2B/ethereum.org-Design-System?node-id=16-58&t=ziK8H00GQthayEmc-1

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 47a160e
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/668e894ba5cda50008d7e999
😎 Deploy Preview https://deploy-preview-13329--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 45 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nloureiro nloureiro added ui design 💅 This issue needs UI design design All the issues related to design should use this tag design system this label will be used in all issues related to design system labels Jul 5, 2024
@wackerow wackerow marked this pull request as draft July 5, 2024 20:28
@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Jul 15, 2024

@nloureiro if you'd like, in order to keep the workflow consistent, I can go through the UI Test check as a dev to make sure the application of this new color scheme is expected from the coding side. There are currently 181 changes I can review and approve.

And I can keep an eye on this PR and go through this check as new changes come in.

@nloureiro
Copy link
Contributor Author

@nloureiro if you'd like, in order to keep the workflow consistent, I can go through the UI Test check as a dev to make sure the application of this new color scheme is expected from the coding side. There are currently 181 changes I can review and approve.

And I can keep an eye on this PR and go through this check as new changes come in.

Oh, great.
That would be a good idea, is it possible to do it?

keep in mind that we will have purple as the main color but will start to use 3 more colors on the UI
red/magenta, blue, and green.

@TylerAPfledderer
Copy link
Contributor

@nloureiro if you'd like, in order to keep the workflow consistent, I can go through the UI Test check as a dev to make sure the application of this new color scheme is expected from the coding side. There are currently 181 changes I can review and approve.

And I can keep an eye on this PR and go through this check as new changes come in.

Oh, great.
That would be a good idea, is it possible to do it?

keep in mind that we will have purple as the main color but will start to use 3 more colors on the UI
red/magenta, blue, and green.

Good to know, thank you!

I can simply go through the changes to approve or deny. I probably don't have the ability to push changes in the code.

@nloureiro
Copy link
Contributor Author

This PR served it's purpose, it's time to rest

@nloureiro nloureiro closed this Aug 15, 2024
@github-actions github-actions bot added the abandoned This has been abandoned or will not be implemented label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned This has been abandoned or will not be implemented design system this label will be used in all issues related to design system design All the issues related to design should use this tag ui design 💅 This issue needs UI design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants