-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed ui on find-wallet [Fixes #13421] #13426
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Production on left, PR on the right
Hey @nipunh, I'm not sure this is accomplishing what is needed here...
Looks like we've altered the card width itself, and how it's internal contents are handled... This is not what we want to change.
We need to adjust how these cards are displayed in the parent container to remove the white space on the right edge (outside of the card itself) when there is more to scroll to.
From issue:
overflow the wrapper till the end of the screen like this and have no empty space on the right side
Does this make sense?
ping @nipunh |
> Production on left, PR on the right Yes, I will make the required changes |
cc @corwintines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nipunh
@all-contributors can you add @nipunh for code |
I've put up a pull request to add @nipunh! 🎉 |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description
fixed ui on find-wallet Fixes #13421
We can also provide arrows like this indicating more items in the grid, clicking on arrow will scroll the cards