Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ui on find-wallet [Fixes #13421] #13426

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

nipunh
Copy link
Contributor

@nipunh nipunh commented Jul 18, 2024

Description

fixed ui on find-wallet Fixes #13421

Screenshot 2024-07-18 at 3 09 20 PM
  1. Made changes in scroll-bar css to show it by default.
  2. Increased the width of cards for overflowing on right size

We can also provide arrows like this indicating more items in the grid, clicking on arrow will scroll the cards
Screenshot 2024-07-18 at 3 09 20 PM

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 64157e8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/669969b3fe44060008784787
😎 Deploy Preview https://deploy-preview-13426--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 39 (🔴 down 12 from production)
Accessibility: 92 (no change from production)
Best Practices: 87 (🔴 down 11 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Production on left, PR on the right

Hey @nipunh, I'm not sure this is accomplishing what is needed here...

Looks like we've altered the card width itself, and how it's internal contents are handled... This is not what we want to change.

We need to adjust how these cards are displayed in the parent container to remove the white space on the right edge (outside of the card itself) when there is more to scroll to.

From issue:

overflow the wrapper till the end of the screen like this and have no empty space on the right side

Does this make sense?

@konopkja
Copy link
Contributor

ping @nipunh

@nipunh
Copy link
Contributor Author

nipunh commented Jul 24, 2024

image > Production on left, PR on the right

Hey @nipunh, I'm not sure this is accomplishing what is needed here...

Looks like we've altered the card width itself, and how it's internal contents are handled... This is not what we want to change.

We need to adjust how these cards are displayed in the parent container to remove the white space on the right edge (outside of the card itself) when there is more to scroll to.

From issue:

overflow the wrapper till the end of the screen like this and have no empty space on the right side

Does this make sense?

Yes, I will make the required changes

@konopkja
Copy link
Contributor

cc @corwintines

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nipunh

@corwintines
Copy link
Member

@all-contributors can you add @nipunh for code

Copy link
Contributor

@corwintines

I've put up a pull request to add @nipunh! 🎉

@corwintines corwintines merged commit d91b1be into ethereum:dev Sep 16, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Sep 16, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: UI on find-wallet
4 participants