Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadcn migration - search modal #13541

Merged
merged 16 commits into from
Aug 13, 2024
Merged

Shadcn migration - search modal #13541

merged 16 commits into from
Aug 13, 2024

Conversation

pettinarip
Copy link
Member

Description

Search modal implementation using Shadcn.

@github-actions github-actions bot added config ⚙️ Changes to configuration files dependencies 📦 Changes related to project dependencies labels Jul 30, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit bbeeccc
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66bbd32ff7bf790008cf7be5
😎 Deploy Preview https://deploy-preview-13541--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 43 (🔴 down 5 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (🔴 down 14 from production)
SEO: 93 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

pettinarip
pettinarip commented Jul 30, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@pettinarip pettinarip marked this pull request as ready for review August 8, 2024 16:31
@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Aug 13, 2024
wackerow
wackerow approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, thanks @pettinarip!

@wackerow wackerow merged commit 2fb4687 into dev Aug 13, 2024
3 checks passed
@wackerow wackerow deleted the shadcn-search branch August 13, 2024 21:42
@Wachira3712
Copy link

ครับ

This was referenced Aug 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
config ⚙️ Changes to configuration files dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pettinarip @Wachira3712 @wackerow