fix event tracking: wallet page [Fixes #13420] #13576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitt-gupta
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
cc @wackerow |
corwintines
approved these changes
Aug 27, 2024
This was referenced Sep 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes the event tracking in wallets page.
Description
In the wallets page, multiple links and buttons does not have event tracking using matomo.
Following are the buttons which require event tracking:
Find a wallet
How to use a wallet
Internal link name with title: How to create an ethereum account.
Internal link name with title: How to use a wallet
External Link with title : Protecting yourself and your funds
External link with title: Keys to keep your crypto safe.
In the ButtonLink the mamoto event tracking already implemented, so i have used the same.
In the Card Component no event tracking has been added, so i added an optional prop to add the event tracking options.
Related Issue
Fixes Issue: #13420