Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShadCN] refactor(layout/static): convert layout to ShadCN #13588

Merged
merged 5 commits into from
Aug 21, 2024
Merged

[ShadCN] refactor(layout/static): convert layout to ShadCN #13588

merged 5 commits into from
Aug 21, 2024

Conversation

TylerAPfledderer
Copy link
Contributor

@TylerAPfledderer TylerAPfledderer commented Aug 6, 2024 •
edited
Loading

Description

Migrate the Static layout for ShadCN/Tailwind

@netlify Netlify
Copy link

netlify bot commented Aug 6, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 50ade13
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66c5e5bab0e2a00008933dc0
😎 Deploy Preview https://deploy-preview-13588--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 40 (🔴 down 9 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 88 (🔴 down 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer changed the title refactor(layout/static): convert layout to ShadCN [ShadCN] refactor(layout/static): convert layout to ShadCN Aug 6, 2024
@TylerAPfledderer
Copy link
Contributor Author

TylerAPfledderer commented Aug 9, 2024 •
edited
Loading

Leaving this in draft for now. I would say that the #13569 is a blocker here; it is establishing the import of the new buttons and links, which means movement of various files.

Once that is done and merged, then update this PR and the Link import for the this layout.

@TylerAPfledderer TylerAPfledderer marked this pull request as ready for review August 15, 2024 02:29
pettinarip
pettinarip reviewed Aug 21, 2024
View reviewed changes
src/layouts/Static.tsx Outdated Show resolved Hide resolved
pettinarip
pettinarip approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pettinarip pettinarip merged commit 7436407 into ethereum:dev Aug 21, 2024
8 of 9 checks passed
@TylerAPfledderer TylerAPfledderer deleted the refactor/shadcn-static-layout branch August 22, 2024 01:43
This was referenced Sep 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerAPfledderer @pettinarip